some ImmersiveMode unit tests failing with single process mash |
|||
Issue description
-ImmersiveModeControllerAshTest.LockedFullscreenDisablesImmersive
-ImmersiveModeControllerAshTest.RegularToLockedFullscreenDisablesImmersive
-ImmersiveModeControllerAshTest.TabAndBrowserFullscreen
are all failing. Here's an example trace. The problem appears to be that Ash doesn't know about the
browser widget or doesn't create a WindowState object for it, or just doesn't have time to do that while the test is running (need to flush/wait for mojo messages?)
[ RUN ] ImmersiveModeControllerAshTest.LockedFullscreenDisablesImmersive
../../chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc:324: Failure
Value of: browser_view()->GetWidget()->IsFullscreen()
Actual: false
Expected: true
Stack trace:
#0 0x557cc52e236c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x557cc52e1d49 testing::internal::AssertHelper::operator=()
#2 0x557cc51c87b5 ImmersiveModeControllerAshTest_LockedFullscreenDisablesImmersive_Test::TestBody()
../../chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc:326: Failure
Expected equality of these values:
ash::SHELF_HIDDEN
Which is: 2
shelf()->visibility_state()
Which is: 0
Stack trace:
#0 0x557cc52e236c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x557cc52e1d49 testing::internal::AssertHelper::operator=()
#2 0x557cc51c89aa ImmersiveModeControllerAshTest_LockedFullscreenDisablesImmersive_Test::TestBody()
../../chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc:331: Failure
Value of: browser_view()->fullscreen_control_host_for_test()
Actual: false
Expected: true
Stack trace:
#0 0x557cc52e236c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x557cc52e1d49 testing::internal::AssertHelper::operator=()
#2 0x557cc51c8b63 ImmersiveModeControllerAshTest_LockedFullscreenDisablesImmersive_Test::TestBody()
[121301:121301:1128/175954.368573:1383332415729:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
,
Nov 30
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/216033b081e4f1f5f31c1229c9f508dcdd434a22 commit 216033b081e4f1f5f31c1229c9f508dcdd434a22 Author: Evan Stade <estade@chromium.org> Date: Wed Dec 05 21:59:09 2018 Convert three ImmersiveModeControllerAshTests from unit to browser tests This is necessary for single process mash because the tests verify Ash behavior wrt fullscreen changes in top level windows. Unit tests use a TestWindowTree (so Ash doesn't know about or react to changes in client widgets/windows), whereas browser tests use a real ws::WindowTree. Bug: 910249 Change-Id: Icc21fa42c6c32e6d7f0d30eb08494880fff9a1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1357300 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#614116} [modify] https://crrev.com/216033b081e4f1f5f31c1229c9f508dcdd434a22/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/216033b081e4f1f5f31c1229c9f508dcdd434a22/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/216033b081e4f1f5f31c1229c9f508dcdd434a22/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/216033b081e4f1f5f31c1229c9f508dcdd434a22/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc [modify] https://crrev.com/216033b081e4f1f5f31c1229c9f508dcdd434a22/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter [modify] https://crrev.com/216033b081e4f1f5f31c1229c9f508dcdd434a22/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Dec 18
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26f413ecff8a53e1c151cc33d8404dff7083b15e commit 26f413ecff8a53e1c151cc33d8404dff7083b15e Author: Evan Stade <estade@chromium.org> Date: Wed Jan 16 21:02:22 2019 Enable immersive mode browser test on Mash. Fixed by crrev.com/44972d384a132962c1b Bug: 910249 Change-Id: Id2fe72670326b943f3e5cdb58c83b43175bb565f Reviewed-on: https://chromium-review.googlesource.com/c/1409689 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#623356} [modify] https://crrev.com/26f413ecff8a53e1c151cc33d8404dff7083b15e/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/26f413ecff8a53e1c151cc33d8404dff7083b15e/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter |
|||
►
Sign in to add a comment |
|||
Comment 1 by osh...@chromium.org
, Nov 30