New issue
Advanced search Search tips

Issue 910243 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Large test suites packages don't get run on the Fuchsia debug bot.

Project Member Reported by fdegans@chromium.org, Nov 29

Issue description

content_unittests, webrunner_browsertests and webrunner_unittests consistently fail on the Fuchsia debug bot due to their size.
Sample failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-dbg/4032

Sample log:
[00227.884] pkgsvr: pkgfs: asking amber to fetch 2538 blobs for {webrunner_browsertests 0}
[00227.893] pkgsvr: pkgfs: amber.GetBlob("b6f9ba0be4b48e8bb18079c07811ca499b161e89a449e957d0932a460a008cdc") failed: ErrPeerClosed: zx.Channel.Write
[00227.905] pkgsvr: pkgfs: amber.GetBlob("1e1cb6d3a2367cd1910478b5ec23db7d2364929e82964d6df1d5c148975a7850") failed: ErrPeerClosed: zx.Channel.Write
[00227.917] pkgsvr: pkgfs: amber.GetBlob("c0e07a6794be1535c4d971e6d9ef37667febea7b6c843b218037cc90d524e530") failed: ErrPeerClosed: zx.Channel.Write
[00256.428] Blobfs::AddBlocks FVM Extend failure
[00256.428] Blobfs has run out of space on persistent storage.
[00256.429]     Could not allocate 66437120 bytes
[00256.429]     Total data bytes  : 310378496
[00256.429]     Used data bytes   : 220168192
[00256.429]     Preallocated bytes: 19890176
[00256.429]     Free data bytes   : 70320128
[00256.429]     This allocation failure is the result of fragmentation.
[...]

The issue is that the FVM is limited to 1GB and these packages need to be copied in full to the /data portion of the FVM store before they can be extracted and installed. With the way we currently build debug builds, they are more than 700MB large, leaving no space for extraction.
We can work around this by using compiler optimization options to lower the binary size.
 
Description: Show this description
Owner: kmarshall@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Pri-2 M-73 Pri-1
Owner: fdegans@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c58e9eabf4ee9f79ba668bf31395dada547cb8bb

commit c58e9eabf4ee9f79ba668bf31395dada547cb8bb
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Thu Nov 29 20:23:56 2018

[Fuchsia] Lower the debug build binary size.

This changes the optimization level for debug builds on Fuchsia to
optimize for size. This fixes an issue where the KVM would run out of
space on the Fuchsia debug component bot.

Bug:  910243 
Change-Id: I7b1257c26b820af97b7c29151cde8f1a52692f5e
Reviewed-on: https://chromium-review.googlesource.com/c/1352621
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612337}
[modify] https://crrev.com/c58e9eabf4ee9f79ba668bf31395dada547cb8bb/build/config/compiler/BUILD.gn

Status: Fixed (was: Started)
The test suites are back to being run.

Sign in to add a comment