New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 910240 link

Starred by 1 user
Status: Fixed
Owner:
mukai@chromium.org
Closed: Dec 20
Cc:
steve...@chromium.org
yhanada@chromium.org
omrilio@chromium.org
█ blakeo@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 646565
Blocking:
issue 905430



Sign in to add a comment

ArcInputMethodManagerServiceTest.DisableFallbackVirtualKeyboard failing in single process mash

Project Member Reported by est...@chromium.org, Nov 29 
[ RUN      ] ArcInputMethodManagerServiceTest.DisableFallbackVirtualKeyboard
[94288:94288:1128/175240.208530:1382898255683:WARNING:test_network_connection_tracker.cc(65)] Creating more than one TestNetworkConnectionTracker
../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc:930: Failure
Value of: client->is_keyboard_enabled()
  Actual: false
Expected: true
Stack trace:
#0 0x561551feb36c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x561551fead49 testing::internal::AssertHelper::operator=()
#2 0x5615519e9e91 arc::ArcInputMethodManagerServiceTest_DisableFallbackVirtualKeyboard_Test::TestBody()

[  FAILED  ] ArcInputMethodManagerServiceTest.DisableFallbackVirtualKeyboard (90 ms)

Comment 1 by osh...@chromium.org, Nov 30

Components: UI>Input>VirtualKeyboard Platform>Apps>ARC

Comment 2 by shend@chromium.org, Dec 3

Owner: yhanada@chromium.org
Status: Assigned (was: Untriaged)
Hi Yuichiro-san, could you PTAL? Thanks!

Comment 3 by yhanada@chromium.org, Dec 3 

Sure!
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93bc5e433d4a9c215c91c639d2d6fab8b25d949

commit d93bc5e433d4a9c215c91c639d2d6fab8b25d949
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Mon Dec 03 09:01:31 2018

Fix ArcInputMethodManagerServiceTest.DisableFallbackVirtualKeyboard in single process mash.

Bug:  910240 
Test: unit_tests --gtest_filter=*ArcInput* --enable-features=SingleProcessMash
Change-Id: I1e836b6743026c901f1f328d96213d2a3eeb3c24
Reviewed-on: https://chromium-review.googlesource.com/c/1358292
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613026}
[modify] https://crrev.com/d93bc5e433d4a9c215c91c639d2d6fab8b25d949/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc

Comment 5 by yhanada@google.com, Dec 3

Status: Fixed (was: Assigned)

Comment 6 by est...@chromium.org, Dec 3 

thanks!

Comment 7 by est...@chromium.org, Dec 6

Status: Assigned (was: Fixed)
still failing on FYI bots (did you run with DCHECKs enabled?)

[ RUN      ] ArcInputMethodManagerServiceTest.DisableFallbackVirtualKeyboard
[13240:13240:1206/123410.287060:18840346685:WARNING:test_network_connection_tracker.cc(65)] Creating more than one TestNetworkConnectionTracker
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 8 parallel jobs.
[13240:13240:1206/123410.363167:18840422759:FATAL:gpu_host_impl.cc(182)] Check failed: GetFontRenderParams().Get(). 
#0 0x55e5101d960f base::debug::StackTrace::StackTrace()
#1 0x55e51013be4b logging::LogMessage::~LogMessage()
#2 0x55e5118a754c viz::GpuHostImpl::GpuHostImpl()
#3 0x55e50d80a9b4 content::GpuProcessHost::Init()
#4 0x55e50d80a432 content::GpuProcessHost::Get()
#5 0x55e50d8046e3 content::BrowserGpuClientDelegate::EnsureGpuHost()
#6 0x55e5118a563b viz::GpuClient::EstablishGpuChannel()
#7 0x55e5118a50ac viz::GpuClient::PreEstablishGpuChannel()
#8 0x55e50d99c0bc content::RenderProcessHostImpl::Init()
#9 0x55e50d9a987f content::(anonymous namespace)::SpareRenderProcessHostManager::WarmupSpareRenderProcessHost()
#10 0x55e50d7f3c87 content::RenderFrameHostManager::GetSiteInstanceForNavigation()
#11 0x55e50d7f248b content::RenderFrameHostManager::GetSiteInstanceForNavigationRequest()
#12 0x55e50d7f1b8f content::RenderFrameHostManager::GetFrameHostForNavigation()
#13 0x55e50d7f1a6d content::RenderFrameHostManager::DidCreateNavigationRequest()
#14 0x55e50d7985d7 content::FrameTreeNode::CreatedNavigationRequest()
#15 0x55e50d7c1276 content::NavigatorImpl::Navigate()
#16 0x55e50d7a1ce0 content::NavigationControllerImpl::NavigateWithoutEntry()
#17 0x55e50d7a1038 content::NavigationControllerImpl::LoadURLWithParams()
#18 0x55e50d7a0ecd content::NavigationControllerImpl::LoadURL()
#19 0x55e512b4211d (anonymous namespace)::ChromeKeyboardContentsDelegate::OpenURLFromTab()
#20 0x55e50dae7e55 content::WebContentsImpl::OpenURL()
#21 0x55e512b418df ChromeKeyboardWebContents::LoadContents()
#22 0x55e512b41789 ChromeKeyboardWebContents::ChromeKeyboardWebContents()
#23 0x55e512b40700 ChromeKeyboardControllerClient::OnLoadKeyboardContentsRequested()
#24 0x55e50dfb4b7d ash::mojom::KeyboardControllerObserverStubDispatch::Accept()
#25 0x55e50f897726 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#26 0x55e50f8a84c6 mojo::FilterChain::Accept()
#27 0x55e50f898ab5 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#28 0x55e50f89e53b mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#29 0x55e50f89d960 mojo::internal::MultiplexRouter::Accept()
#30 0x55e50f8a84c6 mojo::FilterChain::Accept()
#31 0x55e50f895529 mojo::Connector::ReadSingleMessage()
#32 0x55e50f895f31 mojo::Connector::ReadAllAvailableMessages()
#33 0x55e50f895dd9 mojo::Connector::OnHandleReadyInternal()
#34 0x55e50a819257 _ZNKR4base17RepeatingCallbackIFvN8download18DownloadDangerTypeEEE3RunES2_
#35 0x55e5108b9394 mojo::SimpleWatcher::OnHandleReady()
#36 0x55e50d365971 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz14GpuServiceImplEFvN3gfx21GenericSharedMemoryIdEiRKN3gpu9SyncTokenEEJNS_7WeakPtrIS4_EES6_iS8_EEEFvvEE7RunImplISC_NSt3__15tupleIJSE_S6_iS8_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE
#37 0x55e5101fc761 base::debug::TaskAnnotator::RunTask()
#38 0x55e510144e00 base::MessageLoopImpl::RunTask()
#39 0x55e5101453c3 base::MessageLoopImpl::DoWork()
#40 0x55e5101f74d9 base::MessagePumpLibevent::Run()
#41 0x55e5101449a8 base::MessageLoopImpl::Run()
#42 0x55e51016a419 base::RunLoop::Run()
#43 0x55e50f8a727a mojo::internal::ControlMessageProxy::FlushForTesting()
#44 0x55e50bf4cf84 arc::ArcInputMethodManagerServiceTest_DisableFallbackVirtualKeyboard_Test::TestBody()
#45 0x55e50c662a21 testing::Test::Run()
#46 0x55e50c66366f testing::TestInfo::Run()
#47 0x55e50c663b97 testing::TestCase::Run()
#48 0x55e50c66fdd7 testing::internal::UnitTestImpl::RunAllTests()
#49 0x55e50c66f94d testing::UnitTest::Run()
#50 0x55e50f7d7f01 base::TestSuite::Run()
#51 0x55e50f7d9f9d base::(anonymous namespace)::LaunchUnitTestsInternal()
#52 0x55e50f7d9e01 base::LaunchUnitTests()
#53 0x55e50f7cce0f main
#54 0x7fa031c7ef45 __libc_start_main
#55 0x55e50a68752a _start

[8482/12550] ArcInputMethodManagerServiceTest.DisableFallbackVirtualKeyboard (CRASHED)

Comment 8 by steve...@chromium.org, Dec 7 

I just saw this locally but it's flaky. I couldn't get it to fail by itself, even with gtest_repeat=100. When I saw it I was using --gtest_filter=*eyboard*:

out/Release/unit_tests --gtest_filter=*eyboard* --enable-feature=SingleProcesMash

Comment 9 by yhanada@chromium.org, Dec 10 

hmm, the stack trace is different and I didn't see it when I ran it locally. Let me try to reproduce it.

Comment 10 by yhanada@chromium.org, Dec 10 

I ran the test 100 times with "dcheck_always_on=true" gn arg and couldn't reproduce the failure.

Comment 11 by mukai@chromium.org, Dec 17

Cc: yhanada@chromium.org
Owner: mukai@chromium.org
will take a look

Comment 12 by steve...@chromium.org, Dec 17

Owner: steve...@chromium.org
Status: Started (was: Assigned)
This was fixed here:
https://chromium-review.googlesource.com/c/1358292

I'll update the filter.

Comment 13 by steve...@chromium.org, Dec 17 

Oh, I see this was kept open because of the crash in GpuHostImpl::GpuHostImpl(). I think we should file a new issue if that continues. I'm going to go ahead and remove this from the filter for now.

Comment 14 by steve...@chromium.org, Dec 18 

Interesting. This failed twice on the trybot, but not locally with either a Debug or Release build. Investigating further.
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f235779f9b75525fc33b08b8181ce52816926d33

commit f235779f9b75525fc33b08b8181ce52816926d33
Author: Jun Mukai <mukai@chromium.org>
Date: Thu Dec 20 19:58:00 2018

Decouple AshKeyboardController and AshKeyboardUI a bit

This CL cleans up the initialization of AshKeyboardUI, since some
tests assume to use TestKeyboardUI (ash/keyboard/test_keyboard_ui)
but the existing AshKeyboardController always creates AshKeyboardUI.

With this CL; the following KeyboardUI class will be used:
- unit tests (whatever uses AshTestHelper): TestKeyboardUI
- Mash/SingleProcessMash: AshKeyboardUI
- otherwise: ChromeKeyboardUI

Bug:  910240 
Test: trybot
Change-Id: I9d45e8ad25af40ce4dbbd7e437d2b28fab7f325c
Reviewed-on: https://chromium-review.googlesource.com/c/1380968
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618299}
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/keyboard/ash_keyboard_controller.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/keyboard/ash_keyboard_controller.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/keyboard/ash_keyboard_ui.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/keyboard/ash_keyboard_ui.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/keyboard/test_keyboard_ui.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/keyboard/test_keyboard_ui.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell_delegate.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell_delegate_mash.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell_delegate_mash.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell_init_params.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/shell_init_params.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/test/ash_test_helper.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/test_shell_delegate.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ash/test_shell_delegate.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/browser/ui/ash/ash_shell_init.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/browser/ui/ash/chrome_shell_delegate.h
[add] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/browser/ui/ash/keyboard/chrome_keyboard_ui_factory.cc
[add] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/browser/ui/ash/keyboard/chrome_keyboard_ui_factory.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/chrome/test/base/view_event_test_platform_part_chromeos.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ui/keyboard/BUILD.gn
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ui/keyboard/keyboard_ui.cc
[modify] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ui/keyboard/keyboard_ui.h
[add] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ui/keyboard/keyboard_ui_factory.cc
[add] https://crrev.com/f235779f9b75525fc33b08b8181ce52816926d33/ui/keyboard/keyboard_ui_factory.h

Comment 16 by mukai@chromium.org, Dec 20

Cc: steve...@chromium.org
Owner: mukai@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment