Build all targets on macOS dbg CQ builder. |
||||||
Issue descriptionI've had two changes recently which built fine on Rel but not on Dbg. The trybots all passed on my change which eventually broke the build and had to be backed out. I don't know if this is a common occurrence or not but adding in a Debug Mac Trybot would be nice if Obj-C or _mac.cc files are included in the patchset.
,
Nov 29
,
Dec 4
The "analyze" step runs on all CQ bots (rel and dbg both), and only builds targets affected by the files changed in the CL. The tryjob linked in #1 is from Feb of this year, and tested this cl: https://chromium-review.googlesource.com/c/chromium/src/+/912760/7 Given that that CL changes ChromeOS-only code, it's not surprising that a Mac bot detected that nothing needed compiling. If you have a recent CL that caused analyze to not compile anything but should have, please provide a link. Otherwise I'm closing this as WAI. Thanks.
,
Dec 4
I think that was an incomplete copy-paste. The right URL is https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_compile_dbg_ng/193379. That touched a .mm file (only Mac/iOS) and yet analyze reported "No compile necessary"
,
Dec 4
I *think* this is WAI given how the bots are configured, at least from my reading of the remoting targets. remoting/host/mac/permission_utils.mm is built as part of //remoting/host/mac/remoting_me2me_host (https://codesearch.chromium.org/chromium/src/remoting/host/mac/BUILD.gn?rcl=f11883f1961a13fa97ef3a27c0d121e5a266001c&l=61). That target appears to be built as part of //remoting:remoting_all in some configurations (https://codesearch.chromium.org/chromium/src/remoting/BUILD.gn?rcl=00196ab622b5ea471c32703ff17926e035d66e53&l=78) but not by any of the test targets built by Mac Builder (dbg) or its triggered bots (which is what's mirrored by mac_chromium_compile_dbg_ng). We could consider having Mac Builder (dbg) (and thus mac_chromium_compile_dbg_ng) build 'all', though.
,
Dec 7
I agree that Mac Builder (dbg) should build 'all', assuming this doesn't run into capacity issues. It looks like we've got 25 builderse, and most of the them, there are several idle. In the last month, there was only 1 very brief period when pending time spiked > 1 hour. The next highest spike was 15min. I think that's sufficient capacity to enable building all test targets.
,
Dec 7
,
Dec 10
https://chromium-review.googlesource.com/c/chromium/src/+/1370949
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcfb31a91b024ce331664ee5184622530cdd257b commit dcfb31a91b024ce331664ee5184622530cdd257b Author: Ben Pastene <bpastene@chromium.org> Date: Tue Dec 11 17:57:29 2018 Configure "Mac Builder (dbg)" to build "all". Will watch for cycle time increases on the CQ bot: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/mac_chromium_compile_dbg_ng R=dpranke, erikchen, jbudorick Bug: 910227 Change-Id: I73f6e5cc18e707aebe6689034a734ee96fbaa97b Reviewed-on: https://chromium-review.googlesource.com/c/1370949 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#615577} [modify] https://crrev.com/dcfb31a91b024ce331664ee5184622530cdd257b/testing/buildbot/chromium.mac.json [modify] https://crrev.com/dcfb31a91b024ce331664ee5184622530cdd257b/testing/buildbot/waterfalls.pyl |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by joedow@chromium.org
, Nov 29