New issue
Advanced search Search tips

Issue 910218 link

Starred by 2 users
Status: Assigned
Owner:
voit@google.com
Cc:
jdufault@chromium.org
isandrk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Show full disclosure warning for managed sessions

Project Member Reported by voit@google.com, Nov 29 
Show full disclosure warning on public session login screen
in case "Managed Session" behavior is enforced by policy.
 
Also we need to add tests and UI integration for changes made in
https://chromium-review.googlesource.com/c/chromium/src/+/1337492

as discussed there.

Comment 1 by voit@google.com, Nov 29

Description: Show this description

Comment 2 by voit@google.com, Nov 29

Summary: Show full disclosure warning for managed sessions (was: Add tests and debug UI integration for Managed Sessions UI)

Comment 3 by osh...@chromium.org, Nov 30

Components: Enterprise

Comment 4 by isandrk@chromium.org, Dec 3

Cc: isandrk@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f99f63b996b368bbc07a6ae760d9dabc7085ff0a

commit f99f63b996b368bbc07a6ae760d9dabc7085ff0a
Author: Zakhar Voit <voit@google.com>
Date: Tue Dec 04 00:37:33 2018

[Managed Session] Change warning UI based on managed session settings

Show warning icon on public session login screen when managed
sessions are enabled.


Bug: 910218
Change-Id: I119dd321c6d9a7bf8dd3b3da533b8774e9620bc7
Reviewed-on: https://chromium-review.googlesource.com/c/1337492
Commit-Queue: Zakhar Voit <voit@google.com>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613352}
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/ash_strings.grd
[add] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/ash_strings_grd/IDS_ASH_LOGIN_MANAGED_SESSION_MONITORING_WARNING.png.sha1
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO.png.sha1
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO_ITEM_1.png.sha1
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO_ITEM_2.png.sha1
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO_ITEM_3.png.sha1
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/login_screen_controller.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/login_screen_controller.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/ui/login_expanded_public_account_view.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/ui/login_expanded_public_account_view.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/login/ui/public_account_warning_dialog.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/ui/views/user_board_view.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/user_board_view_mojo.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/user_board_view_mojo.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/users/chrome_user_manager.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/users/chrome_user_manager.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/chromeos/login/users/mock_user_manager.h
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc
[modify] https://crrev.com/f99f63b996b368bbc07a6ae760d9dabc7085ff0a/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h

Comment 6 by isandrk@chromium.org, Dec 4

Labels: M-72 Merge-Request-72

Comment 7 by djmm@google.com, Dec 4

Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe

commit c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe
Author: Ivan Sandrk <isandrk@google.com>
Date: Wed Dec 05 10:30:39 2018

[M72 Merge][Managed Session] Change warning UI based on managed session settings

Show warning icon on public session login screen when managed
sessions are enabled.


(cherry picked from commit f99f63b996b368bbc07a6ae760d9dabc7085ff0a)

Bug: 910218
Change-Id: I119dd321c6d9a7bf8dd3b3da533b8774e9620bc7
Reviewed-on: https://chromium-review.googlesource.com/c/1337492
Commit-Queue: Zakhar Voit <voit@google.com>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613352}
Reviewed-on: https://chromium-review.googlesource.com/c/1362894
Cr-Commit-Position: refs/branch-heads/3626@{#70}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/ash_strings.grd
[add] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/ash_strings_grd/IDS_ASH_LOGIN_MANAGED_SESSION_MONITORING_WARNING.png.sha1
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO.png.sha1
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO_ITEM_1.png.sha1
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO_ITEM_2.png.sha1
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/ash_strings_grd/IDS_ASH_LOGIN_PUBLIC_ACCOUNT_MONITORING_INFO_ITEM_3.png.sha1
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/login_screen_controller.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/login_screen_controller.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/ui/login_expanded_public_account_view.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/ui/login_expanded_public_account_view.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/login/ui/public_account_warning_dialog.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/ui/views/user_board_view.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/user_board_view_mojo.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/user_board_view_mojo.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/users/chrome_user_manager.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/users/chrome_user_manager.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/chromeos/login/users/mock_user_manager.h
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc
[modify] https://crrev.com/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h
Project Member

Comment 9 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: CommitLog-Audit-Violation Merge-Without-Approval
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 10 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe

Commit: c0bb202eb0b9698c6d59e4fb981ca5cbd92b09fe
Author: isandrk@google.com
Commiter: isandrk@chromium.org
Date: 2018-12-05 10:30:39 +0000 UTC

[M72 Merge][Managed Session] Change warning UI based on managed session settings

Show warning icon on public session login screen when managed
sessions are enabled.


(cherry picked from commit f99f63b996b368bbc07a6ae760d9dabc7085ff0a)

Bug: 910218
Change-Id: I119dd321c6d9a7bf8dd3b3da533b8774e9620bc7
Reviewed-on: https://chromium-review.googlesource.com/c/1337492
Commit-Queue: Zakhar Voit <voit@google.com>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613352}
Reviewed-on: https://chromium-review.googlesource.com/c/1362894
Cr-Commit-Position: refs/branch-heads/3626@{#70}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 12 by voit@google.com, Jan 8

Labels: -ReleaseBlock-Stable
jdufault@ I'm removing RBS label since Debug UI and UI tests CL was merged and it was the actual blocker.
Project Member

Comment 13 by bugdroid, Today (9 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53f7f0bcb83d86f1ab52c0954dcf25c58a6b24e

commit f53f7f0bcb83d86f1ab52c0954dcf25c58a6b24e
Author: Zakhar Voit <voit@google.com>
Date: Tue Jan 22 21:46:33 2019

Fix GetActiveProxyConfigDictionary crash

Fix ProxyConfigServiceImpl::GetActiveProxyConfigDictionary when
called in an envinronment without a primary user (e.g. public
sessions only setup).

Bug: 910218
Change-Id: Ibe5b6dc50cb4260c325c530ebce5e15e6af3eaa6
Reviewed-on: https://chromium-review.googlesource.com/c/1424888
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624937}
[modify] https://crrev.com/f53f7f0bcb83d86f1ab52c0954dcf25c58a6b24e/chromeos/network/proxy/proxy_config_service_impl.cc
►

Sign in to add a comment