IdentityGetAuthTokenFunction: Rename GetIdentityManager() to GetMojoIdentityManager() |
|||
Issue descriptionThis is in preparation for converting the remaining usage of ProfileOAuth2TokenService and friends in that class to the C++ IdentityManager. As part of this, |identity_manager_| should be renamed to |mojo_identity_manager_|.
,
Dec 5
I'm fixing this as it's blocking 910203
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fab936e4bba3c670ec547989ea11cc1fd002ef2 commit 1fab936e4bba3c670ec547989ea11cc1fd002ef2 Author: Sergio Villar Senin <svillar@igalia.com> Date: Thu Dec 13 09:55:46 2018 Rename IdentityGetAuthTokenFunction::GetIdentityManager() It should be named GetMojoIdentityManager() instead as it isn't returning an identity::IdentityManager but a identity::mojom::IdentityManager. BUG: 910202 Change-Id: Ia8f7fc3023c9606d32c66dd4cd99a4deb3e7a0d2 Reviewed-on: https://chromium-review.googlesource.com/c/1363183 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#616255} [modify] https://crrev.com/1fab936e4bba3c670ec547989ea11cc1fd002ef2/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc [modify] https://crrev.com/1fab936e4bba3c670ec547989ea11cc1fd002ef2/chrome/browser/extensions/api/identity/identity_get_auth_token_function.h
,
Dec 13
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97ba8f05f634628e04a09a196a3ae82a1e7d2131 commit 97ba8f05f634628e04a09a196a3ae82a1e7d2131 Author: Sergio Villar Senin <svillar@igalia.com> Date: Tue Jan 15 11:37:19 2019 Convert IdentityGetAuthTokenFunction from using PO2TS to IdentityManager The ProfileOAuth2TokenService was used for several things from checking the availability of refresh tokens for a given account to starting access token requests. In order to completely migrate it to IdentityManager a new API had to be added to both IdentityManager and AccountTokenFetcher since it was not possible to request an access token by passing a client id and secret. Last but not least, the identity_manager_ attribute was renamed to mojo_identity_manager_. Bug: 910202 , 910203 Change-Id: I97de7156c8901de4a566b0133448c2d83cd4b37c Reviewed-on: https://chromium-review.googlesource.com/c/1370279 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#622815} [modify] https://crrev.com/97ba8f05f634628e04a09a196a3ae82a1e7d2131/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/97ba8f05f634628e04a09a196a3ae82a1e7d2131/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc [modify] https://crrev.com/97ba8f05f634628e04a09a196a3ae82a1e7d2131/chrome/browser/extensions/api/identity/identity_get_auth_token_function.h [modify] https://crrev.com/97ba8f05f634628e04a09a196a3ae82a1e7d2131/services/identity/public/cpp/access_token_fetcher.cc [modify] https://crrev.com/97ba8f05f634628e04a09a196a3ae82a1e7d2131/services/identity/public/cpp/access_token_fetcher.h [modify] https://crrev.com/97ba8f05f634628e04a09a196a3ae82a1e7d2131/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/97ba8f05f634628e04a09a196a3ae82a1e7d2131/services/identity/public/cpp/identity_manager.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by blundell@chromium.org
, Nov 29