New issue
Advanced search Search tips

Issue 910198 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: IsValidIndex(index)

Project Member Reported by ClusterFuzz, Nov 29

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5843571112148992

Fuzzer: libFuzzer_pdf_cfx_barcode_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  IsValidIndex(index)
  fxcrt::WideString::operator
  CBC_DefaultPlacement::module
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=612013:612020

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5843571112148992

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 29

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 29

Cc: tsepez@chromium.org thestig@chromium.org weili@chromium.org jam@chromium.org dsinclair@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Nov 29

Labels: Test-Predator-Auto-Owner
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/a043ccb00d3fd96057c374ea5362a7a8c7a5f160 (Remove remaining "exceptions" in fxbarcode.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
https://pdfium-review.googlesource.com/c/pdfium/+/46073
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/ce4d0ba8984d5b71a1e17a37860b4b9bb4f3da77

commit ce4d0ba8984d5b71a1e17a37860b4b9bb4f3da77
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Nov 29 22:52:29 2018

Fix WideString() vs {} confusion in fxbarcode.

Commit a043ccb0 mixed up the two in CBC_ErrorCorrection::EncodeECC200().
Take another look, pdfium::Optional is unnecessary and failure can be
represented with an empty WideString.

BUG= chromium:910198 

Change-Id: I6e506287acb5ed39da2b0b73d00ad00154b06463
Reviewed-on: https://pdfium-review.googlesource.com/c/46073
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/ce4d0ba8984d5b71a1e17a37860b4b9bb4f3da77/fxbarcode/datamatrix/BC_DataMatrixWriter.cpp
[modify] https://crrev.com/ce4d0ba8984d5b71a1e17a37860b4b9bb4f3da77/fxbarcode/datamatrix/BC_ErrorCorrection.cpp
[modify] https://crrev.com/ce4d0ba8984d5b71a1e17a37860b4b9bb4f3da77/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp
[modify] https://crrev.com/ce4d0ba8984d5b71a1e17a37860b4b9bb4f3da77/fxbarcode/datamatrix/BC_ErrorCorrection.h
[modify] https://crrev.com/ce4d0ba8984d5b71a1e17a37860b4b9bb4f3da77/fxbarcode/datamatrix/BC_HighLevelEncoder.h

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38c448a6131c6808c935fa8e79027872b96f34af

commit 38c448a6131c6808c935fa8e79027872b96f34af
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Nov 30 03:57:33 2018

Roll src/third_party/pdfium f737d4bdb38d..75a486e0a03a (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/f737d4bdb38d..75a486e0a03a


git log f737d4bdb38d..75a486e0a03a --date=short --no-merges --format='%ad %ae %s'
2018-11-30 thestig@chromium.org Export defines to dependents of the "pdfium" target.
2018-11-29 thestig@chromium.org Bump up |kMaxObjectNumber|.
2018-11-29 thestig@chromium.org Make CBC_SymbolInfo::Lookup() return a const pointer.
2018-11-29 thestig@chromium.org Fix WideString() vs {} confusion in fxbarcode.


Created with:
  gclient setdep -r src/third_party/pdfium@75a486e0a03a

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:910009 , chromium:910198 
TBR=dsinclair@chromium.org

Change-Id: I84cd9d7ccecc0acb72b8e8fe91394b486affea8f
Reviewed-on: https://chromium-review.googlesource.com/c/1356130
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612552}
[modify] https://crrev.com/38c448a6131c6808c935fa8e79027872b96f34af/DEPS

Project Member

Comment 8 by ClusterFuzz, Nov 30

ClusterFuzz has detected this issue as fixed in range 612547:612554.

Detailed report: https://clusterfuzz.com/testcase?key=5843571112148992

Fuzzer: libFuzzer_pdf_cfx_barcode_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  IsValidIndex(index)
  fxcrt::WideString::operator
  CBC_DefaultPlacement::module
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=612013:612020
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=612547:612554

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5843571112148992

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 30

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5843571112148992 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment