New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 910195 link

Starred by 1 user
Status: Started
Owner:
█ loonyb...@chromium.org
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Unload images violating optimized image policies.

Project Member Reported by loonyb...@chromium.org, Nov 29 
If an image is verified to violate feature policy image policy while loading, cancel the load to save bytes / improve performance.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f735c33c6acedbf5248fa51e6cef370e39bad82f

commit f735c33c6acedbf5248fa51e6cef370e39bad82f
Author: Luna Lu <loonybear@chromium.org>
Date: Thu Nov 29 21:33:53 2018

clean up image policy code

1. use ResourceResponse::ExpectedContentLength to get image file size.
2. merge image policy violation check into one place.
    Note: ValidateImagePolicies will later be called through the
    pipeline described in here:
https://docs.google.com/document/d/1B_GnzEItUXsUUQXtB1zMiiov86_U1BCFo1F8g5F_yOY
    to unload unoptimized images as early as possible.


Bug:910195

Change-Id: Iab2fc2fee4f2963c308ca1cc585259021a86b3f2
Reviewed-on: https://chromium-review.googlesource.com/c/1355330
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612362}
[modify] https://crrev.com/f735c33c6acedbf5248fa51e6cef370e39bad82f/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/f735c33c6acedbf5248fa51e6cef370e39bad82f/third_party/blink/renderer/core/layout/layout_image.h
[modify] https://crrev.com/f735c33c6acedbf5248fa51e6cef370e39bad82f/third_party/blink/renderer/core/loader/resource/image_resource_content.cc
►

Sign in to add a comment