New issue
Advanced search Search tips

Issue 910193 link

Starred by 1 user
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Dec 14
Cc:
tandrii@chromium.org
martiniss@chromium.org
jbudorick@chromium.org
st...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 915319



Sign in to add a comment

Add a mechanism to mark builds to not be retried by the CQ.

Project Member Reported by erikc...@chromium.org, Nov 29 
By default, the CQ retries the first N failed builds in a CQ run. We know that some failures [e.g. test failure in test suites with good retry mechanisms] will very likely continue to fail on retry. Retrying those builds significantly increases CQ duration, with minimal change to false rejects.

We will add a mechanism by which builds can be marked by chromium_test recipe as do-not-retry. 

See design doc for more details:
https://docs.google.com/document/d/1yLZhxvwQw60Tiox2LZkIdQ4ZhBF7DuzoJbCFci-dG0U/edit#heading=h.xgjl2srtytjt
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/016601cc21469a272315d694a9add19e0b68328c

commit 016601cc21469a272315d694a9add19e0b68328c
Author: erikchen <erikchen@chromium.org>
Date: Fri Nov 30 15:03:19 2018

Add mechanism for telling CQ to avoid retrying builds.

The function can be called by chromium_test to set a property 'do_not_retry'
which will be propagated into buildbucket output.

Change-Id: I32d8ea925b7cb98d9b25d24226686e116c17801c
Bug:  910193 
Reviewed-on: https://chromium-review.googlesource.com/c/1351542
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/examples/full.expected/with_gerrit_patch_and_target_ref.json
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/examples/full.py
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/examples/full.expected/with_wrong_patch_new.json
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/api.py
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/examples/full.expected/with_git_patch.json
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/README.recipes.md
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/examples/full.expected/with_wrong_patch.json
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/examples/full.expected/with_git_patch_luci.json
[modify] https://crrev.com/016601cc21469a272315d694a9add19e0b68328c/recipes/recipe_modules/tryserver/examples/full.expected/with_gerrit_patch.json
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2f7b4e481837bf402cac354ad1f238b298bc96

commit 1c2f7b4e481837bf402cac354ad1f238b298bc96
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Nov 30 16:31:46 2018

Roll src/third_party/depot_tools 457b44f3cd29..016601cc2146 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/457b44f3cd29..016601cc2146


git log 457b44f3cd29..016601cc2146 --date=short --no-merges --format='%ad %ae %s'
2018-11-30 erikchen@chromium.org Add mechanism for telling CQ to avoid retrying builds.


Created with:
  gclient setdep -r src/third_party/depot_tools@016601cc2146

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:910193 
TBR=agable@chromium.org

Change-Id: Ic44677f54fcd3344cc549da175e6eccb90018bbf
Reviewed-on: https://chromium-review.googlesource.com/c/1356628
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612666}
[modify] https://crrev.com/1c2f7b4e481837bf402cac354ad1f238b298bc96/DEPS
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/5aa3c34e52ab96960862945b9d2ceb6d336160ff

commit 5aa3c34e52ab96960862945b9d2ceb6d336160ff
Author: erikchen <erikchen@google.com>
Date: Wed Dec 12 19:00:54 2018
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/2ec308d7991fad723aaf9c927a9310e980d31f9a

commit 2ec308d7991fad723aaf9c927a9310e980d31f9a
Author: erikchen <erikchen@google.com>
Date: Wed Dec 12 19:30:47 2018
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/dc98228dcae2c59847e207e366d05acdcbb0682d

commit dc98228dcae2c59847e207e366d05acdcbb0682d
Author: erikchen <erikchen@google.com>
Date: Wed Dec 12 19:47:21 2018
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/6b3d4a481e3c5e7a02155c8a8c79416ee96fb92e

commit 6b3d4a481e3c5e7a02155c8a8c79416ee96fb92e
Author: erikchen <erikchen@google.com>
Date: Fri Dec 14 10:15:21 2018
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/3d109058a03d3063b9d4172c77c1b12cf134c50d

commit 3d109058a03d3063b9d4172c77c1b12cf134c50d
Author: erikchen <erikchen@google.com>
Date: Fri Dec 14 16:10:57 2018

Comment 8 by erikc...@chromium.org, Dec 14

Blocking: 915319

Comment 9 by erikc...@chromium.org, Dec 14

Status: Fixed (was: Assigned)

Comment 10 by tandrii@chromium.org, Dec 15 

New cq hasn't been pushed to prod. I intend to do push on Monday.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/349dd78671dfb8637cc8cf440251ad93c93fe4fb

commit 349dd78671dfb8637cc8cf440251ad93c93fe4fb
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Dec 17 19:43:53 2018
►

Sign in to add a comment