New issue
Advanced search Search tips

Issue 910152 link

Starred by 2 users
Status: WontFix
Owner:
svil...@igalia.com
Closed: Dec 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 908855



Sign in to add a comment

Convert GCMAccountTracker from AccountTrackerService to IdentityManager

Project Member Reported by sdefresne@chromium.org, Nov 29 
Should replace the use of AccountTrackerService::GetAccounts() with IdentityManager::GetAccountsWithRefreshTokens()

Comment 1 by svil...@igalia.com, Dec 5

Owner: svil...@igalia.com
Status: Started (was: Available)
Migrating this...

Comment 2 by svil...@igalia.com, Dec 18 

Hmm are we sure we want to convert this? I think there is a misunderstanding here because GCMAccountTracker is *not* using AccountTrackerService::GetAccounts() but AccountTracker::GetAccounts(). They're totally different API, actually the gcm::AccountTracker is implemented using IdentityManager.

Comment 3 by sdefresne@chromium.org, Dec 18

Status: WontFix (was: Started)
No, we do not want to convert those. They got caught by automated "git grep" because GCM exposes an AccountTrackerService with similarly named method to signin's AccountTrackerService :-(
►

Sign in to add a comment