Convert AccountsCollectionViewController to IdentityManager |
||||
Issue descriptionThe code is in ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm. Both uses of ProfileOAuth2TokenService, and AccountTrackerService can be removed. The conversion should proceed like this: - OAuth2TokenServiceObserverBridge should be replaced with identity::IdentityManagerObserverBridge - OAuth2TokenServiceObserverBridgeDelegate should be replaced with IdentityManagerObserverBridgeDelegate - ProfileOAuth2TokenService::GetAccounts and AccountTrackerService::GetAccountInfo should be replaced by IdentityManager::GetAccountsWithRefreshTokens See https://chromium-review.googlesource.com/c/chromium/src/+/1354447 for a similar change in signed_in_accounts_view_controller.mm
,
Jan 8
Starting to work on this.
,
Jan 8
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6591cea445a7367ac5ccf0b2d4dcd6b759ee71e4 commit 6591cea445a7367ac5ccf0b2d4dcd6b759ee71e4 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Thu Jan 10 01:56:16 2019 [s13n] Convert AccountsTableViewController to IdentityManager This CL only migrates AccountsTableViewController production code away from OAuth2TokenServiceObserverBridge, OAuth2TokenServiceObserverBridgeDelegate, ProfileOAuth2TokenService and AccountTrackerService. Bug: 910151 Change-Id: I24c1a3ec80d18d7feed7fa2fcff3ed939e629d2d Reviewed-on: https://chromium-review.googlesource.com/c/1399698 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#621415} [modify] https://crrev.com/6591cea445a7367ac5ccf0b2d4dcd6b759ee71e4/ios/chrome/browser/ui/settings/accounts_table_view_controller.mm
,
Jan 14
|
||||
►
Sign in to add a comment |
||||
Comment 1 by blundell@chromium.org
, Dec 11