Convert SyncSettingsCollectionViewController to use IdentityManager |
||||
Issue descriptionThe code is in ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm. Both uses of ProfileOAuth2TokenService, and AccountTrackerService can be removed. The conversion should proceed like this: - OAuth2TokenServiceObserverBridge should be replaced with identity::IdentityManagerObserverBridge - OAuth2TokenServiceObserverBridgeDelegate should be replaced with IdentityManagerObserverBridgeDelegate - ProfileOAuth2TokenService::GetAccounts and AccountTrackerService::GetAccountInfo should be replaced by IdentityManager::GetAccountsWithRefreshTokens See https://chromium-review.googlesource.com/c/chromium/src/+/1354447 for a similar change in signed_in_accounts_view_controller.mm
,
Nov 30
Taking this
,
Dec 5
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59b00a733b6b789e20deed6167ef662c835e6cba commit 59b00a733b6b789e20deed6167ef662c835e6cba Author: Sergio Villar Senin <svillar@igalia.com> Date: Fri Dec 21 10:18:50 2018 Convert SyncSettingsCollectionViewController to use IdentityManager This CL removes the use of both OAuth2TokenServiceObserverBridge and OAuth2TokenServiceObserverBridgeDelegate replacing them by IdentityManagerObserverBridge and IdentityManagerObserverBridgeDelegate respectiverly. Apart from that, both uses of ProfileOAuth2TokenService, and AccountTrackerService were alse removed in favour of the equivalent calls from IdentityManager API. Bug: 910149 Change-Id: I6f0e63e8d193d11918e736238e0c3b79d875fbef Reviewed-on: https://chromium-review.googlesource.com/c/1384259 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#618494} [modify] https://crrev.com/59b00a733b6b789e20deed6167ef662c835e6cba/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/59b00a733b6b789e20deed6167ef662c835e6cba/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
,
Dec 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sdefresne@chromium.org
, Nov 29