Issue 910147 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	peconn@chromium.org
Closed:	Dec 18
Components:	UI>Browser>Mobile>CustomTabs
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Feature
TL-peconn

Blocking:
issue 888945

Report app name in Clear Chrome Data Dialog

Project Member Reported by peconn@chromium.org, Nov 29

Issue description

when uninstalling, there may be a slightly delay between the Android uninstall dialog and Chrome's uninstall dialog. 

It would be helpful if the app's name was shown in the dialog to help link the two.

Mock: https://screenshot.googleplex.com/vh3wzGvMmgL.png

Comment 1 by peconn@chromium.org, Dec 18

Owner: peconn@chromium.org
Status: Started (was: Available)

The requirements got changed to including the app name in the title instead, as in the attached screenshot.

	2018-12-18_14-22-25-TitleUninstall.png 95.8 KB View Download

Comment 2 by hwi@chromium.org, Dec 18

LGTM. Thanks peconn@!

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1813cac222287db89ce9e8b2a51ab8d3a01064ad

commit 1813cac222287db89ce9e8b2a51ab8d3a01064ad
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Dec 18 17:30:01 2018

🤝 Show app name on uninstall dialog.

Bug:  910147 
Change-Id: I5fc76f992b9a63a30d03f953ac7d9d9a05b46713
Reviewed-on: https://chromium-review.googlesource.com/c/1382445
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617547}
[modify] https://crrev.com/1813cac222287db89ce9e8b2a51ab8d3a01064ad/chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClearDataDialogActivity.java
[modify] https://crrev.com/1813cac222287db89ce9e8b2a51ab8d3a01064ad/chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppBroadcastReceiver.java
[modify] https://crrev.com/1813cac222287db89ce9e8b2a51ab8d3a01064ad/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/1813cac222287db89ce9e8b2a51ab8d3a01064ad/chrome/android/junit/src/org/chromium/chrome/browser/browserservices/ClientAppBroadcastReceiverTest.java

Comment 4 by peconn@chromium.org, Dec 18

Status: Fixed (was: Started)

►

Issue 910147 link

Issue metadata

Report app name in Clear Chrome Data Dialog

Issue description

Comment 1 by peconn@chromium.org, Dec 18

Comment 1 Deleted

Comment 2 by hwi@chromium.org, Dec 18

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Dec 18

Comment 3 Deleted

Comment 4 by peconn@chromium.org, Dec 18

Comment 4 Deleted

Sign in to add a comment