New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910145 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox edit state showing Google logo

Project Member Reported by f...@chromium.org, Nov 29

Issue description

I was testing out one-click unelide, and ended up in a state where the Google logo is shown next to non-Google URLs in the edit state. See attachments.

I'm on Mac with latest canary (72.0.3625.0). (#omnibox-ui-one-click-unelide set to enabled.)


 
Screen Shot 2018-11-29 at 7.42.53 AM.png
7.6 KB View Download
Screen Shot 2018-11-29 at 7.42.57 AM.png
12.6 KB View Download
Labels: OS-Mac
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a1133a0a03490e165640af6bc9dfd5d070c06ce

commit 8a1133a0a03490e165640af6bc9dfd5d070c06ce
Author: Tommy C. Li <tommycli@chromium.org>
Date: Mon Dec 03 19:55:50 2018

Omnibox: Make OmniboxView::GetIcon more robust for steady state elisions

Whenever the user unelides the URL, the omnibox also enters
user_input_in_progress_ mode.

This is was harmless before, but since then we have started displaying
suggestion favicons in the omnibox, the current page's security
indicator is being clobbered by the page's favicon during unelision.

This is not correct, since unelision is supposed to be as unobtrusive
as possible.

This is going to become more noticable now that Ctrl+L triggers
unelision, as well as our future planned work for One-Click-Unelide.

This CL replaces the old logic, and keeps showing the current page's
security indicator until the user actually modifies the user text.

Bug: 874592, 906223, 910145
Change-Id: I8a5619d4408b09d2e9f98fd5ce011ecbd2cab085
Reviewed-on: https://chromium-review.googlesource.com/c/1351564
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613203}
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/location_bar_model.h
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/location_bar_model_impl.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_edit_model.h
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_edit_model_unittest.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_view.cc

Sign in to add a comment