New issue
Advanced search Search tips

Issue 910123 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 29
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: DumpAccessibilityTreeTest.AccessibilityVideoControls



Sign in to add a comment

DumpAccessibilityTreeTest.AccessibilityVideoControls is flaky

Project Member Reported by Findit, Nov 29

Issue description


Flaky test: DumpAccessibilityTreeTest.AccessibilityVideoControls
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/5253
Test output log: https://chromium-swarm.appspot.com/task?id=4178873032449b10
Culprit (100.0% confidence): r612160
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKiAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNTI1My9uZXR3b3JrX3NlcnZpY2VfY29udGVudF9icm93c2VydGVzdHMgb24gVWJ1bnR1LTE2LjA0L1JIVnRjRUZqWTJWemMybGlhV3hwZEhsVWNtVmxWR1Z6ZEM1QlkyTmxjM05wWW1sc2FYUjVWbWxrWlc5RGIyNTBjbTlzY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20DumpAccessibilityTreeTest.AccessibilityVideoControls&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKiAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNTI1My9uZXR3b3JrX3NlcnZpY2VfY29udGVudF9icm93c2VydGVzdHMgb24gVWJ1bnR1LTE2LjA0L1JIVnRjRUZqWTJWemMybGlhV3hwZEhsVWNtVmxWR1Z6ZEM1QlkyTmxjM05wWW1sc2FYUjVWbWxrWlc5RGIyNTBjbTlzY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/769b90879117a57d8b8805e9b4205e3fe068d86a

commit 769b90879117a57d8b8805e9b4205e3fe068d86a
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Nov 29 14:27:10 2018

Revert "[Accessibility] Volume slider reads out level in percentages."

This reverts commit cf0717195ed5798c1970f4897682a1517c229e75.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 612160 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2YwNzE3MTk1ZWQ1Nzk4YzE5NzBmNDg5NzY4MmExNTE3YzIyOWU3NQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/5253

Sample Failed Step: network_service_content_browsertests on Ubuntu-16.04

Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls

Original change's description:
> [Accessibility] Volume slider reads out level in percentages.
> 
> This CL makes it such that the volume level is read out as a percentage
> in aria. This CL also amplifies how the accessibility information is
> given to aria, by setting attributes instead of explicitly creating
> accessibility nodes.
> 
> Bug:  905024 
> Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> Reviewed-on: https://chromium-review.googlesource.com/c/1337298
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612160}

Change-Id: I06f47bd929725e2176c9cc9a48e20993d1cb78f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  905024 ,  910123 
Reviewed-on: https://chromium-review.googlesource.com/c/1354196
Cr-Commit-Position: refs/heads/master@{#612184}
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/content/test/data/accessibility/html/video-controls-expected-auralinux.txt
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/content/test/data/accessibility/html/video-controls-expected-blink.txt
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/content/test/data/accessibility/html/video-controls.html
[delete] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/769b90879117a57d8b8805e9b4205e3fe068d86a/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc

Status: Fixed (was: Untriaged)
The failing test was added by the culprit and removed by the revert.

Sign in to add a comment