Flaky test: WindowSelectorControllerTest.OcclusionTest Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30330 Test output log: https://chromium-swarm.appspot.com/task?id=41774e10a5f6a710 Culprit (100.0% confidence): r611323 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKWAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzMwMzMwL3NpbmdsZV9wcm9jZXNzX21hc2hfYXNoX3VuaXR0ZXN0cy9WMmx1Wkc5M1UyVnNaV04wYjNKRGIyNTBjbTlzYkdWeVZHVnpkQzVQWTJOc2RYTnBiMjVVWlhOMAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WindowSelectorControllerTest.OcclusionTest&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKWAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzMwMzMwL3NpbmdsZV9wcm9jZXNzX21hc2hfYXNoX3VuaXR0ZXN0cy9WMmx1Wkc5M1UyVnNaV04wYjNKRGIyNTBjbTlzYkdWeVZHVnpkQzVQWTJOc2RYTnBiMjVVWlhOMAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Culprit looks correct (WindowSelectorControllerTest.OcclusionTest is added by the culprit CL). Reverting.
Hi, can you hold the revert? This looks to me that it's specific to single process mash, so I'll file a bug and disable the test for single process mash.
> disabling the test on single-process runs. Sounds good. The failures are on the ASAN LSAN bot, not ordinal Linux bots.
Draft CL is under codereview: https://chromium-review.googlesource.com/c/chromium/src/+/1355883
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a06485ba70afc41ab805c85e8caaf0d110cf6e0c commit a06485ba70afc41ab805c85e8caaf0d110cf6e0c Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Nov 29 23:25:39 2018 Skip WindowSelectorControllerTest.OcclustionTest in single process mash This also increased the timeout for test because it can take longer on asan. TBR=hiroshige@chromium.org, xiyuan@chromium.org Bug: 910303 , 910105 Test: OcclustionTest is skipped in single process mash Change-Id: I669d7343255980dd540c98aa645e5f14c641c371 Reviewed-on: https://chromium-review.googlesource.com/c/1355883 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612429} [modify] https://crrev.com/a06485ba70afc41ab805c85e8caaf0d110cf6e0c/ash/wm/overview/window_selector_controller_unittest.cc [modify] https://crrev.com/a06485ba70afc41ab805c85e8caaf0d110cf6e0c/testing/buildbot/filters/chromeos.single_process_mash.ash_unittests.filter
The test is green after r612429. Thanks.
Comment 1 by hirosh...@chromium.org
, Nov 29