New issue
Advanced search Search tips

Issue 910092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary 'Extensions' external link present in settings sidebar menu list even Extensions is not available for Guest users.

Reported by dchau...@etouch.net, Nov 29

Issue description

Chrome Version: 72.0.3625.0 (Official Build) Revision	2c59a8a07afb8b11354406e63270d1cbeb582c47-refs/branch-heads/3625@{#1} (32/64-bit)
OS: Windows(7, 8, 8.1, 10), Mac(10.13.1 , 10.13.6 , 10.14.2) and Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch Chrome and open Guest window.
2. Navigate to chrome://settings page.
3. Click to open main menu list and observe.

Actual: Unnecessary 'Extensions' link present in main menu list even Extensions is not available for Guest users.
Expected: Extensions link should not present in main menu list as Extensions is not available for Guest users.

This is a regression issue,broken in M-67 series, below is manual regression range:

Good build: 67.0.3381.0 (Revision: 545919)
Bad build: 67.0.3382.0 (Revision: 546346)

You are probably looking for a change made after 546032 (known good), but no later than 546033 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/8bfc0e2c79faab6656159f8c86472a4c4953997e..496814ca5225455f342e5b8d799d8fd2d759af35

Suspecting: https://chromium.googlesource.com/chromium/src/+/496814ca5225455f342e5b8d799d8fd2d759af35

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: This issue is also seen on Stable #70.0.3538.110, Beta #71.0.3578.75 & Dev #72.0.3622.0

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mp4
534 KB View Download
Expected behavior.mp4
465 KB View Download
Labels: -Pri-1 Pri-3
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfe8b0b68ddc9e13337b11db13f889f59162cfb8

commit dfe8b0b68ddc9e13337b11db13f889f59162cfb8
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Nov 30 20:00:38 2018

Settings WebUI: hide extensions link from settings menu when in guest mode

Bug:  910092 
Change-Id: I20f669bf401437ac52695274a01f32e08d427170
Reviewed-on: https://chromium-review.googlesource.com/c/1355843
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612738}
[modify] https://crrev.com/dfe8b0b68ddc9e13337b11db13f889f59162cfb8/chrome/browser/resources/settings/page_visibility.js
[modify] https://crrev.com/dfe8b0b68ddc9e13337b11db13f889f59162cfb8/chrome/browser/resources/settings/settings_menu/settings_menu.html

Status: Fixed (was: Started)

Sign in to add a comment