Regression : Chrome does not decrypt saved password on clicking 'Show password' icon for the first instance.
Reported by
avsha...@etouch.net,
Nov 29
|
||||||
Issue descriptionChrome Version : 72.0.3625.0 (Official Build) 2c59a8a07afb8b11354406e63270d1cbeb582c47-refs/branch-heads/3625@{#1} 32/64 bit OS : Mac(10.13.6, 10.13.1, 10.14.2), Linux(14.04 LTS), Windows(7,8,10) Precondition : Sign in into chrome with an account that has at least one synced/saved password entry in 'chrome://settings/passwords' What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://settings/passwords page. 2. Click on 'Show password' icon (authentication dialog appears) and close the authentication dialog. 3. Click on 'More actions' icon and select 'Details' option. 4. In 'Saved password details' overlay, click on 'Show password' icon, enter valid credentials and hit 'Enter'. 5. Click on 'Show password' icon and observe. Actual Result : Chrome does not decrypt saved password on clicking 'Show password' icon for the first instance. Expected Result : Chrome should decrypt saved password after step 5. This is a regression issue broken in M-72 and below is the bisect info: Good Build : 72.0.3581.0 (Revision : 599548) Bad Build : 72.0.3582.0 (Revision : 599847) Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/6861eea1bcb6308d3b4bd31331114b015bc6bb2c..085ecdf2a18350a1964a65ef5b48a663ae7228ec Suspecting : r599728 ? @jdoerrie : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. We need to click 'Show password' icon twice in order to decrypt saved password. 2. Able to repro issue in Dev #72.0.3622.0 as well. 3. Unable to provide bisect using per-revision script as it shows "We don't have enough builds error message" 4. Tried on other machines but still getting the same error, hence provided suspect through 'Chromium bisect' Thank you..!
,
Nov 30
,
Dec 3
,
Dec 4
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a839b5a2d78377bfd22336486f6d15d5d9121bbf commit a839b5a2d78377bfd22336486f6d15d5d9121bbf Author: Jan Wilken Dörrie <jdoerrie@chromium.org> Date: Wed Dec 05 01:07:48 2018 [Settings WebUI] Fix Simultaneous Diplay of Password This change fixes a UI bug where a hidden password was not correctly updated when both the <password-list-item> and <password-edit-dialog> were setting the same password at the same time. Bug: 910081 Change-Id: If1ac5298ceebe1f12003083d87a85d1fa66a1f71 Reviewed-on: https://chromium-review.googlesource.com/c/1354275 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612787}(cherry picked from commit 0ffd8cd3a5eabc72cb5fe385d2ed59a2f914a024) Reviewed-on: https://chromium-review.googlesource.com/c/1362496 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#60} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/a839b5a2d78377bfd22336486f6d15d5d9121bbf/chrome/browser/resources/settings/autofill_page/passwords_section.js
,
Dec 5
--------- Update : --------- Verified above issue in latest Dev build #72.0.3626.7 on Mac(10.13.1, 10.13.6, 10.14.2), Windows(7,8,10) & Linux(14.04 LTS) OS and the issue is fixed. Now, user is able to decrypt saved password in first instance on clicking 'Show password' icon. Hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..!
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a839b5a2d78377bfd22336486f6d15d5d9121bbf Commit: a839b5a2d78377bfd22336486f6d15d5d9121bbf Author: jdoerrie@chromium.org Commiter: jdoerrie@chromium.org Date: 2018-12-05 01:07:48 +0000 UTC [Settings WebUI] Fix Simultaneous Diplay of Password This change fixes a UI bug where a hidden password was not correctly updated when both the <password-list-item> and <password-edit-dialog> were setting the same password at the same time. Bug: 910081 Change-Id: If1ac5298ceebe1f12003083d87a85d1fa66a1f71 Reviewed-on: https://chromium-review.googlesource.com/c/1354275 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612787}(cherry picked from commit 0ffd8cd3a5eabc72cb5fe385d2ed59a2f914a024) Reviewed-on: https://chromium-review.googlesource.com/c/1362496 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#60} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Nov 30