New issue
Advanced search Search tips

Issue 910077 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 909584



Sign in to add a comment

[bisect-kit] failed to bisect chrome local build between 72.0.3612.0 and 72.0.3618.0 (garbage in out dir)

Project Member Reported by kcwu@chromium.org, Nov 29

Issue description

After 72.0.3618.0 build, ninja failed when build 72.0.3612.0 with following message

[9/15967] CXX obj/chrome/browser/chromeos/device_policy_remover_generated/device_policy_remover.o
FAILED: obj/chrome/browser/chromeos/device_policy_remover_generated/device_policy_remover.o 
../../build/cros_cache/chrome-sdk/tarballs/quawks+11244.0.0+target_toolchain/bin/x86_64-cros-linux-gnu-clang++ -MMD -MF obj/chrome/browser/chromeos/device_policy_remover_generated/device_policy_remover.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DCR_CLANG_REVISION=\"346388-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCR_SYSROOT_HASH=e7c53f04bd88d29d075bfd1f62b073aeb69cbe09 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -m64 -march=x86-64 -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -Wno-defaulted-function-deleted -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf -ggnu-pubnames -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-shorten-64-to-32 -std=c++14 -fno-exceptions -fno-rtti --sysroot=../../build/cros_cache/chrome-sdk/tarballs/quawks+11244.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz -fvisibility-inlines-hidden -pipe -march=corei7 -fno-split-dwarf-inlining -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -stdlib=libc++ -Wno-inline-asm -B../../build/cros_cache/chrome-sdk/tarballs/quawks+11244.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -Wno-unknown-warning-option -c gen/chrome/browser/chromeos/device_policy_remover.cc -o obj/chrome/browser/chromeos/device_policy_remover_generated/device_policy_remover.o
gen/chrome/browser/chromeos/device_policy_remover.cc:307:15: error: no member named 'clear_device_wifi_fast_transition_enabled' in 'enterprise_management::ChromeDeviceSettingsProto'
    policies->clear_device_wifi_fast_transition_enabled();
    ~~~~~~~~  ^
gen/chrome/browser/chromeos/device_policy_remover.cc:311:15: error: no member named 'clear_device_display_resolution' in 'enterprise_management::ChromeDeviceSettingsProto'
    policies->clear_device_display_resolution();
    ~~~~~~~~  ^
gen/chrome/browser/chromeos/device_policy_remover.cc:315:15: error: no member named 'clear_plugin_vm_allowed' in 'enterprise_management::ChromeDeviceSettingsProto'
    policies->clear_plugin_vm_allowed();
    ~~~~~~~~  ^
gen/chrome/browser/chromeos/device_policy_remover.cc:319:15: error: no member named 'clear_plugin_vm_image' in 'enterprise_management::ChromeDeviceSettingsProto'
    policies->clear_plugin_vm_image();
    ~~~~~~~~  ^
4 errors generated.


Looks like there are some garbage left in out*/gen directory. 

Workaround: build succeed after deleted out*/ directory.

 
I don't have good idea how to solve this problem yet. Local hack to delete out*/ directory in order to make bisect of  issue 909627  going forward.

Summary: [bisect-kit] failed to bisect chrome local build between 72.0.3612.0 and 72.0.3618.0 (garbage in out dir) (was: [bisect-kit] failed to bisect chrome local build between 72.0.3612.0 and 72.0.3618.0)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/782b80a9ec6f88d7b880b2c58a14c1f0bafa7e39

commit 782b80a9ec6f88d7b880b2c58a14c1f0bafa7e39
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Mon Dec 03 06:07:33 2018

bisect-kit: retry if build chrome failed

Sometimes, build chrome failed because previous build leave some garbage
in out directory. Because the garbage issue happens rarely, we clean up
and retry only if build failed instead of clean up every time.

BUG=chromium:910077
TEST=switch_cros_cr_localbuild_internal.py 72.0.3618.0 then 72.0.3612.0

Change-Id: Icba82b34753b19d6b54a375f4abd83ee92b6592d
Reviewed-on: https://chromium-review.googlesource.com/1356687
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/782b80a9ec6f88d7b880b2c58a14c1f0bafa7e39/switch_cros_cr_localbuild_master.py
[modify] https://crrev.com/782b80a9ec6f88d7b880b2c58a14c1f0bafa7e39/bisect_kit/cr_util.py
[modify] https://crrev.com/782b80a9ec6f88d7b880b2c58a14c1f0bafa7e39/switch_cros_cr_localbuild_internal.py
[rename] https://crrev.com/782b80a9ec6f88d7b880b2c58a14c1f0bafa7e39/deploy_chrome_helper.sh

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment