Issue metadata
Sign in to add a comment
|
Regression: Save password bubble does not open on pressing space-bar key
Reported by
sanyam.g...@etouch.net,
Nov 29
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3625.0 (Official Build) Revision 2c59a8a07afb8b11354406e63270d1cbeb582c47-refs/branch-heads/3625@{#1} (64-bit) OS: Mac (10.14.2,10.13.1,10.13.6) OS What steps will reproduce the problem? 1. Launch Chrome and navigate to 'https://www.facebook.com' and save a password. 2. Bring focus to omnibox and press tab to traverse focus to password Key Icon. 3. Press space-bar and observe. Actual: Save password bubble does not open on pressing space-bar key. Expected: Save password bubble should open on pressing space-bar key. This is a regression issue, broken in M-71 series, below is manual regression range: Good build: 71.0.3556.0 (Revision: 592302) Bad build: 71.0.3557.0 (Revision: 592637) You are probably looking for a change made after 592378 (known good), but no later than 592379 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3b3e315db5ef3b1fa846dcdfd93c49948bae6e2e..5540a9cb7ec95a28dcfb97f9ce92520799a71647 Suspect: https://chromium.googlesource.com/chromium/src/+/5540a9cb7ec95a28dcfb97f9ce92520799a71647 @Elly: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. This issue is not reproducible on Windows (7,8,8.1,10) & Linux (14.04 LTS). 2. This issue is also reproducible on Beta #71.0.3578.75 & Dev #72.0.3622.0 Kindly review the attached screen cast for reference. Thank you..!
,
Dec 3
,
Dec 3
I can't test this line on other platforms because TAB doesn't bring the focus to the password icon. It seems impossible to focus. Is it expected?
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/848e9aed3705fe5ca9392b26f90caf4221c96850 commit 848e9aed3705fe5ca9392b26f90caf4221c96850 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Dec 06 16:54:59 2018 passwords: don't eat space KeyPressed on Mac On Mac, KeyPressed is what activates buttons, not KeyReleased, so eating KeyPressed breaks this button. Bug: 910070 Change-Id: I4776bc3b14ac52879ad96c20d55f93126ba349d7 Reviewed-on: https://chromium-review.googlesource.com/c/1361627 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#614386} [modify] https://crrev.com/848e9aed3705fe5ca9392b26f90caf4221c96850/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc [modify] https://crrev.com/848e9aed3705fe5ca9392b26f90caf4221c96850/chrome/browser/ui/views/passwords/manage_passwords_icon_views.h
,
Dec 7
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Nov 29This is probably because of the special case in ManagePasswordsIconViews::OnKeyPressed(): // Space is always ignored because otherwise the bubble appears with the // default button down. Releasing the space is equivalent to clicking this // button. if (event.key_code() == ui::VKEY_SPACE) return true; I suspect that that no longer applies, at least on Mac.