Issue metadata
Sign in to add a comment
|
Regression: 'Font size' slider doesn't slide smoothly on 'Customize fonts' page
Reported by
dchau...@etouch.net,
Nov 29
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3625.0 (Official Build) Revision 2c59a8a07afb8b11354406e63270d1cbeb582c47-refs/branch-heads/3625@{#1} (32/64-bit) OS: Windows (7,8,8.1,10) & Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch Chrome and navigate to chrome://settings/fonts 2. Press 'Tab' key from keyboard to reach the focus at 'Font size' slider. 3. Now press and hold the right/left arrow key from keyboard to slide the 'Font size' slider and observe. Actual: Font size slider doesn't slide smoothly. Expected: Font size slider should slide smoothly. This is a regression issue, broken in M-71 series, below is manual regression range: Good build: 71.0.3564.0 (Revision: 594950) Bad build: 71.0.3565.0 (Revision: 595251) You are probably looking for a change made after 595227 (known good), but no lat er than 595228 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7e8253c958ca8f5105d09468a45155ee8a3053c7..53ecd726c6d4420c25c295c3fafe95fb321f27fa Suspecting: https://chromium.googlesource.com/chromium/src/+/53ecd726c6d4420c25c295c3fafe95fb321f27fa @aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. This issue is not reproducible on Mac OS X(10.14.2,10.13.1,10.13.6) OS. 2. This issue is also reproducible on Beta #71.0.3578.75 & Dev #72.0.3622.0 Kindly review the attached screen cast for reference. Thank you..!
,
Nov 29
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b94fc330081c128068c8fdfb1c8380b5c5f170fd commit b94fc330081c128068c8fdfb1c8380b5c5f170fd Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Nov 30 01:56:03 2018 WebUI: cr-slider, remove position transitions for knob, bar and label The position transitions cause a couple issues. 1. When the slider value is set after being retrieved asynchronously even if the retrieval is quick, the movement will transition from 0 to the retrieved value. This is a minor issue noted in https://crbug.com/896625 . 2. Multiple arrow keyboard events, including repetition from holding down and arrow key, results in a delay in updating the position causing erratic movement of the knob. Bug: 910054 Change-Id: Ibc98638f1c9bda6531a8dea2648654e41a91e37f Reviewed-on: https://chromium-review.googlesource.com/c/1355760 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612508} [modify] https://crrev.com/b94fc330081c128068c8fdfb1c8380b5c5f170fd/chrome/test/data/webui/cr_elements/cr_slider_test.js [modify] https://crrev.com/b94fc330081c128068c8fdfb1c8380b5c5f170fd/ui/webui/resources/cr_elements/cr_slider/cr_slider.html [modify] https://crrev.com/b94fc330081c128068c8fdfb1c8380b5c5f170fd/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
,
Nov 30
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aee@chromium.org
, Nov 29