New issue
Advanced search Search tips

Issue 910050 link

Starred by 1 user
Status: Verified
Owner:
cyan@chromium.org
Closed: Nov 30
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Mouse hover effect is not seen after mouse hover on '+' New Tab icon.

Reported by rp...@etouch.net, Nov 29 
Chrome Version: 72.0.3625.0 (Official Build) Revision 2c59a8a07afb8b11354406e63270d1cbeb582c47-refs/branch-heads/3625@{#1}(64-bit)
OS: Mac OS X(10.14.2,10.13.1,10.13.6)

Steps to reproduce:
1. Launch chrome, Navigate to NTP and hover mouse over '+' New Tab icon near tab strip,observe

Actual Result : Mouse hover effect is not seen after mouse hover on '+' New Tab icon near tab strip
Expected Result : Mouse hover effect should be seen after mouse hover on '+' New Tab icon near tab strip

This is a regression issue broken in M-72 and will soon update other information:
Good Build : 72.0.3624.0 (Revision : 611431)
Bad Build : 72.0.3625.0 (Revision : 611977)
Actual_video.mov
1.6 MB View Download
Expected_video.mov
1.9 MB View Download

Comment 1 by rp...@etouch.net, Nov 29

Labels: hasbisect-per-revision OS-Linux OS-Windows
Owner: cyan@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 611806 (known good), but no later than 611807 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0793ae771a657373792c0cca7ac52964bed51741..7edf9a1030a554baac22b61aaa376b3cd81ca67d

Suspect : https://chromium.googlesource.com/chromium/src/+/7edf9a1030a554baac22b61aaa376b3cd81ca67d

@cyan: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Thank You..!!
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7151077930c7032c57114cdda4fbcb93c652ac8d

commit 7151077930c7032c57114cdda4fbcb93c652ac8d
Author: Charlene Yan <cyan@chromium.org>
Date: Thu Nov 29 21:48:06 2018

Turn on default ink drop handling for new tab button.

InkDropGestureHandler is now InkDropEventHandler and handles mouse and
gesture events.
https://chromium-review.googlesource.com/c/chromium/src/+/1344262

Bug:  910050 
Change-Id: Iab91ca41f100cf3d0ba34b54112bc1fecf49406d
Reviewed-on: https://chromium-review.googlesource.com/c/1355490
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612387}
[modify] https://crrev.com/7151077930c7032c57114cdda4fbcb93c652ac8d/chrome/browser/ui/views/tabs/new_tab_button.cc

Comment 3 by rp...@etouch.net, Nov 30

Labels: TE-Verified-M72 TE-Verified-72.0.3626.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.2) using latest Canary build : 72.0.3626.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mov
2.2 MB View Download

Comment 4 by cyan@chromium.org, Nov 30

Status: Verified (was: Assigned)
►

Sign in to add a comment