New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910049 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[M17n] Press caps or caps+shift key broken for CK keyboard

Project Member Reported by zhan...@chromium.org, Nov 29

Issue description

72.0.3623.3 11310.0.0 dev-channel kevin test
Google input tools version: 72.0.20181122.222570995

Steps;
1.Switch to Sorani Kurdish english-based keyboard or Sorani Kurdish Arabic-based keyboard (CK)
2.Press down Caps key ,or press down caps+shfit key
3.Tap any key again

Actual:
Have not correct output , different character submitted with key-shown characters 

 
Nov 29 2018 5_28 PM.webm
561 KB View Download
Cc: shuchen@chromium.org
Owner: wuyingbing@chromium.org
This issue doesn't repro with the mojo service enabled (feature flag: ImeServiceConnectable).

However, there are some other M17n input methods (with the mojo service enabled) has inconsistent modifier priorities than the VK front-end.

Those is being fixed in Mojo service at https://chromium-review.googlesource.com/c/chromium/src/+/1356735.

And Yingbing will fix the priority for VK rendering in extension.

To QA: pls verify these M17n input methods once the bug is fixed:
ar
ckb_ar
ckb_en
fa
km
lo
ne_inscript
ne_phone
si
ta_inscript
ta_typewriter
th
th_pattajoti
th_tis

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65054bfdd84984501e8054b2f96edacc1bab93a9

commit 65054bfdd84984501e8054b2f96edacc1bab93a9
Author: Shu Chen <shuchen@google.com>
Date: Fri Dec 07 06:48:36 2018

Updates the order of key mappings to match the same as layout rendering in VK.

The modifier importance priority is: Altgr > Shift > Capslock.
So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method.
It will fallback to other key mappings in this order:
 - Shift + Altgr
 - Altgr + Capslock
 - Shift + Capslock
 - Altgr
 - Shift
 - Capslock
 - Normal

Bug:  910049 
Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb
Reviewed-on: https://chromium-review.googlesource.com/c/1356735
Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614628}
[modify] https://crrev.com/65054bfdd84984501e8054b2f96edacc1bab93a9/chromeos/services/ime/public/cpp/rulebased/def/fa.cc
[modify] https://crrev.com/65054bfdd84984501e8054b2f96edacc1bab93a9/chromeos/services/ime/public/cpp/rulebased/def/lo.cc
[modify] https://crrev.com/65054bfdd84984501e8054b2f96edacc1bab93a9/chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
[modify] https://crrev.com/65054bfdd84984501e8054b2f96edacc1bab93a9/chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
[modify] https://crrev.com/65054bfdd84984501e8054b2f96edacc1bab93a9/chromeos/services/ime/public/cpp/rulebased/def/th.cc

Labels: Merge-Request-72
Requesting merge for https://chromium-review.googlesource.com/c/1356735.

As well as the counterpart cl https://chrome-internal-review.googlesource.com/c/chromeos/overlays/chromeos-overlay/+/724250, which contains accumulated fixes in the IME extension.



Project Member

Comment 5 by sheriffbot@chromium.org, Dec 9

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Caps key disappeared in CK in the latest version:
73.0.3635.0/ 11377.0.0 dev-channel kevin test
Input tools version: 72.0.20181203.223901082 


Project Member

Comment 8 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0

commit 38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0
Author: Shu Chen <shuchen@google.com>
Date: Mon Dec 10 03:46:01 2018

Updates the order of key mappings to match the same as layout rendering in VK.

The modifier importance priority is: Altgr > Shift > Capslock.
So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method.
It will fallback to other key mappings in this order:
 - Shift + Altgr
 - Altgr + Capslock
 - Shift + Capslock
 - Altgr
 - Shift
 - Capslock
 - Normal

Bug:  910049 
Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb
Reviewed-on: https://chromium-review.googlesource.com/c/1356735
Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614628}(cherry picked from commit 65054bfdd84984501e8054b2f96edacc1bab93a9)
Reviewed-on: https://chromium-review.googlesource.com/c/1369488
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#170}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0/chromeos/services/ime/public/cpp/rulebased/def/fa.cc
[modify] https://crrev.com/38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0/chromeos/services/ime/public/cpp/rulebased/def/lo.cc
[modify] https://crrev.com/38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0/chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
[modify] https://crrev.com/38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0/chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
[modify] https://crrev.com/38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0/chromeos/services/ime/public/cpp/rulebased/def/th.cc

Status: Fixed (was: Assigned)
"Caps key disappeared" is by design.
Status: Verified (was: Fixed)
Checked in latest version:(73.0.3635.0/11377.0.0 dev-channel kevin test
Input tools version:72.0.20181203.223901082 )

Following combination keys for M17n languages ,bugs not repro; 

ar:	shift_, ok
ckb_ar:	shift_, ok
ckb_en:	shift_,  ok 
fa:	altgr_,  shift_,  altgr_shift_, ok
km:	altgr_,  shift_,  altgt_shift_, ok
lo:	altgr_,  shift_,  altgr_shift_, ok
ne_inscript:	shift_,  ok
ne_phone:	shift_,   ok
si:	altgr_, shift_,  altgt_shift_,  ok
ta_inscript:	altgr_,  shift_, altgr_shift_, ok
ta_typewriter:	shift_,  ok 
th:  altgr_,   shift_,  altgt_shift_, ok
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0

Commit: 38cb93fa8e337cf0dd4b26a96023b01d42d8fcc0
Author: shuchen@google.com
Commiter: shuchen@chromium.org
Date: 2018-12-10 03:46:01 +0000 UTC

Updates the order of key mappings to match the same as layout rendering in VK.

The modifier importance priority is: Altgr > Shift > Capslock.
So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method.
It will fallback to other key mappings in this order:
 - Shift + Altgr
 - Altgr + Capslock
 - Shift + Capslock
 - Altgr
 - Shift
 - Capslock
 - Normal

Bug:  910049 
Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb
Reviewed-on: https://chromium-review.googlesource.com/c/1356735
Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614628}(cherry picked from commit 65054bfdd84984501e8054b2f96edacc1bab93a9)
Reviewed-on: https://chromium-review.googlesource.com/c/1369488
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#170}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment