New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 910027 link

Starred by 2 users
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Nov 29
Cc:
bradhall@chromium.org
w...@chromium.org
phosek@chromium.org
█ nsylvain@google.com
erikc...@chromium.org
jbudorick@chromium.org
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 910029



Sign in to add a comment

content_unittests (without patch) on fuchsia_x64 does not succeed

Project Member Reported by tikuta@chromium.org, Nov 29 
https://chromium-swarm.appspot.com/task?id=41771ae6ccb83c10&refresh=10&show_raw=1

Failure with following error.
```
test_runner.py: error: unrecognized arguments: --test-launcher-retry-limit=0
```

Seems the flag started to be added recently in without patch step.

Comment 1 by tikuta@chromium.org, Nov 29

Cc: erikc...@chromium.org
Looks to be caused by this.
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1351695
Let me revert the CL.

Comment 2 by tikuta@chromium.org, Nov 29

Labels: -Pri-1 Pri-2
Owner: erikc...@chromium.org
Reverted.
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1354141

Let met assign this to erikchen

Comment 3 by tikuta@chromium.org, Nov 29

Labels: -Infra-Troopers -Sheriff-Chromium

Comment 4 by erikc...@chromium.org, Nov 29 

+ wez

I haven't investigated yet, but it sounds like fuchsia test runner doesn't support the flag "--test-launcher-retry-limit", which is supported by all our other test suite runners.

Comment 5 by jbudorick@chromium.org, Nov 29

Cc: bradhall@chromium.org phosek@chromium.org nsylvain@google.com jbudorick@chromium.org
 Issue 910108  has been merged into this issue.

Comment 6 by w...@chromium.org, Nov 29

Components: Internals>PlatformIntegration
Labels: -Pri-2 M-73 Pri-1
Status: Started (was: Untriaged)
Summary: content_unittests (without patch) on fuchsia_x64 does not succeed (was: content_unittests (without patch) on fuchsia_x64 does not success)
Thanks for taking care of this, Erik.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54b72edeef95f4ef98251aa99808297470c5da92

commit 54b72edeef95f4ef98251aa99808297470c5da92
Author: erikchen <erikchen@chromium.org>
Date: Thu Nov 29 18:28:49 2018

Add support for --test-launcher-retry-limit to fuchsia/test_runner.py.

The script now passes the argument through to the test suite. This allows the
default value of 3 to be overridden.

Bug:  910027 
Change-Id: If9bd23756262a84443c097aeafa011e05e84f876
Reviewed-on: https://chromium-review.googlesource.com/c/1354274
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612282}
[modify] https://crrev.com/54b72edeef95f4ef98251aa99808297470c5da92/build/fuchsia/test_runner.py

Comment 8 by w...@chromium.org, Nov 29

Blocking: 910029

Comment 9 by w...@chromium.org, Nov 29

Status: Fixed (was: Started)
►

Sign in to add a comment