New issue
Advanced search Search tips

Issue 910026 link

Starred by 2 users
Status: Verified
Owner:
johntlee@chromium.org
Closed: Dec 11
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: User profile gets selected when clicked and dragging chrome logo.

Reported by aiman.an...@etouch.net, Nov 29 
Chrome Version: 72.0.3624.0 (Official Build) ecf0ae78590173baab05059a89e855b6813588dd-refs/branch-heads/3624@{#1} (32/64 Bit).

OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, click on Avatar icon in omnibox and select Manage People.
2. On manage people window click on 'Chrome' logo in bottom LHS and drag upwards.
3. Observe.

Actual: User profile gets selected when clicking and dragging on chrome logo.
Expected: Profile should no get selected when clicking on chrome logo.

This is a regression issue, broken in M-72 series, and below is the per-revision bisect info:

Good Build: 72.0.3605.0(Revision:606282)
Bad Build: 72.0.3606.0(Revision:606693)

You are probably looking for a change made after 606687 (known good), but no later than 606688 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/dcb55ce2871fe258d30386a85af754d496dfdb62..40239723af8afaa3e7ed317759df1a2872008ebf

Suspect: https://chromium.googlesource.com/chromium/src/+/40239723af8afaa3e7ed317759df1a2872008ebf

@dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Issue is also seen on Dev #72.0.3622.0 build.

Kindly refer the screen cast from the link given below

Thank You!
Actual Result.mp4
452 KB View Download
Expected Result.mp4
485 KB View Download

Comment 1 by dpa...@chromium.org, Nov 30

Labels: -Pri-1 Pri-2
Owner: johntlee@chromium.org
@johntlee: FYI, you can visit chrome://md-user-manager to invoke the same UI in a tab (it makes it a bit easier to debug).
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88f3200143459537d14a3ef2cb60a53f659ce815

commit 88f3200143459537d14a3ef2cb60a53f659ce815
Author: John Lee <johntlee@chromium.org>
Date: Mon Dec 03 20:19:39 2018

WebUI: Prevent dragging from the logo on user manager page

Bug:  910026 
Change-Id: Ifdf6cb51032dd8885297bf3d8d4febaa2e564647
Reviewed-on: https://chromium-review.googlesource.com/c/1357459
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613214}
[modify] https://crrev.com/88f3200143459537d14a3ef2cb60a53f659ce815/chrome/browser/resources/md_user_manager/control_bar.html

Comment 3 by aim...@virtusa.com, Dec 4

Labels: TE-Verified-M73 TE-Verified-73.0.3630.0
Update:

Retested the above issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) OS using latest Canary build #73.0.3630.0 and issue is fixed.

Now, user profile does not get selected when clicked on chrome logo.

Kindly refer the attached screen-cast for reference.

Thank You!
Canary Behaviour.mp4
505 KB View Download

Comment 4 by johntlee@chromium.org, Dec 11

Status: Verified (was: Assigned)
►

Sign in to add a comment