Compiler error when a member field is not properly traced did not trigger for ElementRareData's TraceAfterDispatch. The tracing was fixed in https://crrev.com/c/1354740
ElementRareData::part_ was a TraceWrapperMember so it was not traced but did not cause an error.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9be3f94ae00e77da75d30cd122a06ed2449eb84f commit 9be3f94ae00e77da75d30cd122a06ed2449eb84f Author: Keishi Hattori <keishi@chromium.org> Date: Mon Dec 03 15:05:51 2018 Remove unnecessary casts from TraceWrapperV8Reference tracing Remove unnecessary casts from TraceWrapperV8Reference tracing in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1356442 because blink_gc_plugin will not be able to recognize cast TraceWrapperV8References as traced. Bug: 910023 Change-Id: Icc68c8eac74d5a7c320e6fd575cceba71951c57a Reviewed-on: https://chromium-review.googlesource.com/c/1358318 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#613084} [modify] https://crrev.com/9be3f94ae00e77da75d30cd122a06ed2449eb84f/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc [modify] https://crrev.com/9be3f94ae00e77da75d30cd122a06ed2449eb84f/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc [modify] https://crrev.com/9be3f94ae00e77da75d30cd122a06ed2449eb84f/third_party/blink/renderer/core/script/module_script.h [modify] https://crrev.com/9be3f94ae00e77da75d30cd122a06ed2449eb84f/third_party/blink/renderer/core/workers/experimental/task_worklet_global_scope.cc [modify] https://crrev.com/9be3f94ae00e77da75d30cd122a06ed2449eb84f/third_party/blink/renderer/modules/animationworklet/animator_definition.cc [modify] https://crrev.com/9be3f94ae00e77da75d30cd122a06ed2449eb84f/third_party/blink/renderer/modules/csspaint/css_paint_definition.cc [modify] https://crrev.com/9be3f94ae00e77da75d30cd122a06ed2449eb84f/third_party/blink/renderer/modules/webaudio/audio_worklet_processor_definition.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076 commit 9ccf3fba7dff006ad5f75d5d87c8066a7c58e076 Author: Keishi Hattori <keishi@chromium.org> Date: Tue Dec 04 05:15:10 2018 blink_gc_plugin: Check for untraced TraceWrapperMember and TraceWrapperV8References Adds checks for untraced TraceWrapperMember and TraceWrapperV8References Bug: 910023 Change-Id: Iec646a8e51d117d6469e1587062fc0862858112a Reviewed-on: https://chromium-review.googlesource.com/c/1356442 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#613429} [modify] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/Config.h [modify] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/DiagnosticsReporter.cpp [modify] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/Edge.cpp [modify] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/Edge.h [modify] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/RecordInfo.cpp [modify] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/tests/heap/stubs.h [add] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/tests/trace_wrapper.cpp [add] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/tests/trace_wrapper.h [add] https://crrev.com/9ccf3fba7dff006ad5f75d5d87c8066a7c58e076/tools/clang/blink_gc_plugin/tests/trace_wrapper.txt
Comment 1 by keishi@chromium.org
, Nov 30Labels: -Pri-3 Pri-2
Status: Started (was: Untriaged)
Summary: blink_gc_plugin should check for untraced TraceWrapperMember (was: compiler plugin missed error in TraceAfterDispatch)