New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910016 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocked on:
issue 915038

Blocking:
issue 907353



Sign in to add a comment

[PWA] Treat bookmark apps with open-as-window as PWAs

Project Member Reported by mgiuca@chromium.org, Nov 29

Issue description

Chrome Version: 72
OS: All desktop

What steps will reproduce the problem?
(1) Go to any (non-PWA) website, e.g. http://example.com.
(2) Chrome menu -> More tools -> Create shortcut.
(3) (Chrome OS) find app in launcher / (other OS) find app in chrome:apps.
(4) Right-click -> Open as window
(5) Relaunch app.

What is the expected result?
App acts like a PWA in most respects.

In particular:
- Links in browser to this app show "Open in <app>" for this app.
- Browser three-dot-menu "open in app" should work.
- Notifications open in the app window.
- Chrome OS: Intent picker shows up when navigating to the scope.
- If it's "http" then it shows a location bar at all times [security].

However:
- We have to figure out whether we'll distinguish mixed content (in a PWA, mixed content is blocked, we can't really do that for a non-PWA).
- We wouldn't expect the apps to work offline or have a proper title bar / icon.
- We would not show the "Install" button for non-PWAs on the Chrome menu.

What happens instead?
The above things don't work. We originally set this deliberately, but it's become too hard to manage. By making them behave the same, we can remove a lot of code complexity.

Note: Essentially, all we have to do here is create a "scope" for a bookmark app. The scope should be, roughly, the document URL, minus the query and fragment, minus the last part of the filename. (e.g., "http://example.com/foo/bar?baz=boz" -> "http://example.com/foo/"). [Subject to discussion.]

Note: This will allow us to more easily associate a page with a bookmark app, so soft-blocking  Issue 907353 .
 
For the "Create shortcut" flow would we ignore the scope specified in the manifest? Will they be exempt from any future update mechanism for PWAs?
'Essentially, all we have to do here is create a "scope"'

Sounds correct but we should also analyse / remove any things that do special behavior when the scope is / is not empty, if that makes sense.
#1... my gut says yes, we should ignore scope and generate our own scope. The user is basically telling us "I want a shortcut to this one page, not the whole site."
Status: Assigned (was: Available)
Blockedon: 915038
Owner: dominickn@chromium.org
High-level architecture bug assigning to Dom for TL.

Sign in to add a comment