Some virtual tests about CSP and error logging fail with network service enabled |
|||
Issue descriptionI haven't found the culprit CL yet. These fail when running with network service enabled, e.g., $ third_party/blink/tools/run_web_tests.py --target=Default --additional-driver-flag="--enable-features=NetworkService" virtual/network-error-logging/external/wpt/network-error-logging/sends-report-on-404.https.html Unexpected Failures: * virtual/network-error-logging/external/wpt/network-error-logging/sends-report-on-404.https.html * virtual/network-error-logging/external/wpt/network-error-logging/sends-report-on-cache-validation.https.html * virtual/network-error-logging/external/wpt/network-error-logging/sends-report-on-redirect.https.html * virtual/network-error-logging/external/wpt/network-error-logging/sends-report-on-subdomain-dns-failure.https.html * virtual/network-error-logging/external/wpt/network-error-logging/sends-report-on-success-with-subdomain-policy.https.html * virtual/network-error-logging/external/wpt/network-error-logging/sends-report-on-success.https.html * virtual/outofblink-cors/http/tests/security/isolatedWorld/cross-origin-xhr.html * virtual/reporting-api/external/wpt/content-security-policy/reporting-api/reporting-api-report-only-sends-reports-on-violation.https.sub.html * virtual/reporting-api/external/wpt/content-security-policy/reporting-api/reporting-api-sends-reports-on-violation.https.sub.html * virtual/reporting-api/external/wpt/content-security-policy/reporting-api/reporting-api-works-on-frame-src.https.sub.html Example build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/22872
,
Nov 29
I think this is likely https://chromium-review.googlesource.com/c/chromium/src/+/1351906 Probably the virtual tests configs changed due to that change. Not sure why. Cc'ing some virtual test people.
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fc973744f6967867982b1c1d5e54013855bf74e commit 7fc973744f6967867982b1c1d5e54013855bf74e Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Nov 29 06:40:27 2018 Gardening: Disable some CSP/error-logging virtual tests with NetworkService Started failing recently but I haven't found the culprit CL yet. Bug: 910011 Change-Id: Iaa86f960f86f8ed69df94627eee63275403bf469 TBR: kinuko No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1354737 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612069} [modify] https://crrev.com/7fc973744f6967867982b1c1d5e54013855bf74e/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService
,
Nov 29
Thanks for adding to the failing list! Those new failing virtual/ web_tests are expected. Previously the tests were not being run under --enable-features=NetworkService. https://crrev.com/612007 fixed it so they run on our FYI bot. |
|||
►
Sign in to add a comment |
|||
Comment 1 by falken@chromium.org
, Nov 29