Regression: [NTP] Unnecessary "Done" button gets enabled on selecting 'Reload frame' option of 'Add shortcut' overlay
Reported by
khushal....@etouch.net,
Nov 29
|
||||
Issue descriptionChrome Version: 72.0.3624.0 (Official Build) Revision ecf0ae78590173baab05059a89e855b6813588dd-refs/branch-heads/3624@{#1} (32/64-bit) OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.2) & Linux (14.04 LTS) Pre-condition: Enable the flags 'Enable using the Google local NTP' and 'New Tab Page Custom Links' under chrome://flags/ page. What steps will reproduce the problem? (1) Launch chrome and open NTP. (2) Click on 'Add shortcut' thumbnail (overlay will appear). (3) Now Right click anywhere on overlay except textfield and select the option 'Reload frame'. (4) Observe. Actual Result: Unnecessary "Done" button gets enabled on selecting 'Reload frame' option of 'Add shortcut' overlay. Expected Result: "Done" button should remain disabled even after selecting 'Reload frame' option of 'Add shortcut' overlay. This is a Regression issue seen from 'M-70' and providing the bisect info below: Good Build: 70.0.3504.0 (Revision: 578511) Bad Build: 70.0.3505.0 (Revision: 578873) You are probably looking for a change made after 578557 (known good), but no later than 578558 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/ee3b12babcf98ab2020c827de2fb1e313e0102e5..2fd3efecf7240ef64aec96015ec4052b275e49ab Suspect: https://chromium.googlesource.com/chromium/src/+/2fd3efecf7240ef64aec96015ec4052b275e49ab @yoichio: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: Issue is also seen on M-70 Stable (build #70.0.3538.110), M-71 Beta (build #71.0.3578.62) and M-72 Dev (build #72.0.3622.0). Kindly refer the attached screen-cast. Thank You..!!
,
Nov 30
I just reverted the CL as sheriff. Feel free to revert it again.
,
Nov 30
,
Dec 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ramyan@chromium.org
, Nov 29Labels: -Pri-1 -Target-70 -Target-71 -Target-72 Target-73 Pri-3