Issue metadata
Sign in to add a comment
|
org.chromium.chrome.browser.ntp.NewTabPageTest#testMemoryPressure__EnableInterestFeed is flaky |
||||||||||||||||||||||||
Issue descriptionorg.chromium.chrome.browser.ntp.NewTabPageTest#testMemoryPressure__EnableInterestFeed is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVygAELEgVGbGFrZSJ1Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RNZW1vcnlQcmVzc3VyZV9fRW5hYmxlSW50ZXJlc3RGZWVkDA. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20org.chromium.chrome.browser.ntp.NewTabPageTest#testMemoryPressure__EnableInterestFeed&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVygAELEgVGbGFrZSJ1Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RNZW1vcnlQcmVzc3VyZV9fRW5hYmxlSW50ZXJlc3RGZWVkDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 29
Disabling test at: https://crrev.com/c/1354729 huayinz: you've done some work to fix these tests before. Would you mind taking a look at this?
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94e3324cafafe4de80a191233e7988870b7b5cbc commit 94e3324cafafe4de80a191233e7988870b7b5cbc Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Nov 29 06:23:13 2018 sheriff: Disable flaky NewTabPageTest#testMemoryPressure__EnableInterestFeed TBR=huayinz@chromium.org Bug: 909978 Change-Id: I9347d3f4c344ab19cffa3f3148dc26b557f1a724 Reviewed-on: https://chromium-review.googlesource.com/c/1354729 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612066} [modify] https://crrev.com/94e3324cafafe4de80a191233e7988870b7b5cbc/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
,
Nov 29
Removing Sheriff-Chromium since the issue has an owner.
,
Nov 29
Here is the error message: java.lang.AssertionError at org.chromium.base.DiscardableReferencePool.remove(DiscardableReferencePool.java:87) at org.chromium.chrome.browser.BitmapCache.destroy(BitmapCache.java:101) at org.chromium.chrome.browser.cached_image_fetcher.InMemoryCachedImageFetcher.destroy(InMemoryCachedImageFetcher.java:50) at org.chromium.chrome.browser.feed.FeedImageLoader.destroy(FeedImageLoader.java:63) at org.chromium.chrome.browser.feed.FeedNewTabPage.destroy(FeedNewTabPage.java:259) at org.chromium.chrome.browser.tab.Tab.destroyNativePageInternal(Tab.java:2120) at org.chromium.chrome.browser.tab.Tab.destroy(Tab.java:1791) at org.chromium.chrome.browser.tabmodel.TabModelImpl.destroy(TabModelImpl.java:98) at org.chromium.chrome.browser.tabmodel.TabModelSelectorBase.destroy(TabModelSelectorBase.java:223) at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.destroy(TabModelSelectorImpl.java:324) at org.chromium.chrome.browser.ChromeActivity.onDestroy(ChromeActivity.java:1348) at android.app.Activity.performDestroy(Activity.java:5403) at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1117) at android.support.test.runner.MonitoringInstrumentation.callActivityOnDestroy(MonitoringInstrumentation.java:519) at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3470) at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:3501) at android.app.ActivityThread.access$1400(ActivityThread.java:135) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1249) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5001) at java.lang.reflect.Method.invokeNative(Method.java) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601) at dalvik.system.NativeStart.main(NativeStart.java) I think this suddenly got very flaky after https://chromium-review.googlesource.com/c/chromium/src/+/1343042 Brandon, would you take a look?
,
Nov 29
Thanks Becky, I have a fix in mind.
,
Dec 4
Nice-to-have for M72 so that we have test coverage for this on the official bots. Fix is in the CQ
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/902b7c217e16fbb4906486ba4c33c204b2812bb6 commit 902b7c217e16fbb4906486ba4c33c204b2812bb6 Author: Brandon Wylie <wylieb@chromium.org> Date: Tue Dec 04 23:05:18 2018 Fix potential crash in DiscardableReferencePool Also adding a couple of tests. Bug: 909978 Change-Id: Ic63d5b35a1112c86a3430f4c52f476444b53c666 Reviewed-on: https://chromium-review.googlesource.com/c/1355879 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#613743} [modify] https://crrev.com/902b7c217e16fbb4906486ba4c33c204b2812bb6/base/android/java/src/org/chromium/base/DiscardableReferencePool.java [modify] https://crrev.com/902b7c217e16fbb4906486ba4c33c204b2812bb6/base/android/junit/src/org/chromium/base/DiscardableReferencePoolTest.java [modify] https://crrev.com/902b7c217e16fbb4906486ba4c33c204b2812bb6/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
,
Dec 4
,
Dec 5
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a058f9a2d2a695483c9bdcf69b2b3ebaec9f24a7 commit a058f9a2d2a695483c9bdcf69b2b3ebaec9f24a7 Author: Brandon Wylie <wylieb@chromium.org> Date: Wed Dec 05 23:56:31 2018 Fix potential crash in DiscardableReferencePool Also adding a couple of tests. TBR=nyquist@chromium.org Bug: 909978 Change-Id: Ic63d5b35a1112c86a3430f4c52f476444b53c666 Reviewed-on: https://chromium-review.googlesource.com/c/1355879 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613743}(cherry picked from commit 902b7c217e16fbb4906486ba4c33c204b2812bb6) Reviewed-on: https://chromium-review.googlesource.com/c/1364166 Reviewed-by: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#94} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/a058f9a2d2a695483c9bdcf69b2b3ebaec9f24a7/base/android/java/src/org/chromium/base/DiscardableReferencePool.java [modify] https://crrev.com/a058f9a2d2a695483c9bdcf69b2b3ebaec9f24a7/base/android/junit/src/org/chromium/base/DiscardableReferencePoolTest.java [modify] https://crrev.com/a058f9a2d2a695483c9bdcf69b2b3ebaec9f24a7/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
,
Dec 7
Can this be closed?
,
Dec 7
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a058f9a2d2a695483c9bdcf69b2b3ebaec9f24a7 Commit: a058f9a2d2a695483c9bdcf69b2b3ebaec9f24a7 Author: wylieb@chromium.org Commiter: wylieb@chromium.org Date: 2018-12-05 23:56:31 +0000 UTC Fix potential crash in DiscardableReferencePool Also adding a couple of tests. TBR=nyquist@chromium.org Bug: 909978 Change-Id: Ic63d5b35a1112c86a3430f4c52f476444b53c666 Reviewed-on: https://chromium-review.googlesource.com/c/1355879 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613743}(cherry picked from commit 902b7c217e16fbb4906486ba4c33c204b2812bb6) Reviewed-on: https://chromium-review.googlesource.com/c/1364166 Reviewed-by: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#94} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ortuno@chromium.org
, Nov 29Status: Started (was: Untriaged)