New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 909963 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Media Controls: Use native control in ChromeOS video player

Project Member Reported by jazzhsu@chromium.org, Nov 29

Issue description

Use native controls in ChromeOS video player
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e5886667512c4030f0c77aeb7186ad8d7431f71

commit 2e5886667512c4030f0c77aeb7186ad8d7431f71
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Fri Dec 14 00:38:48 2018

[Media Controls] Use native media controls in Chrome OS video player

Hide default controls and use native controls.

Bug: 909963
Change-Id: Ifa40d499243244fbae8175a13f7bdcfacd8ca199
Reviewed-on: https://chromium-review.googlesource.com/c/1354262
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616528}
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/chrome/browser/about_flags.cc
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/chrome/browser/flag-metadata.json
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/chromeos/chromeos_features.cc
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/chromeos/chromeos_features.h
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2e5886667512c4030f0c77aeb7186ad8d7431f71/ui/file_manager/video_player/js/video_player.js

Cc: denizz@chromium.org
Labels: PM-denizz
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef3d7d28a446c4ca7c13dbbe26cde907391d45f2

commit ef3d7d28a446c4ca7c13dbbe26cde907391d45f2
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Thu Jan 17 19:37:17 2019

[Media Controls] toggle native controls with separate logic

Completely separate current controls and native controls.
Only have basic control functions in native controls.
(implemented previous video and next video in this CL as well)
Will continue adding back features in follow up CLs

Bug: 909963
Change-Id: If14ea5a33b07070f16c760763b2770a952012180
Reviewed-on: https://chromium-review.googlesource.com/c/1383148
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623799}
[modify] https://crrev.com/ef3d7d28a446c4ca7c13dbbe26cde907391d45f2/ui/file_manager/video_player/js/BUILD.gn
[modify] https://crrev.com/ef3d7d28a446c4ca7c13dbbe26cde907391d45f2/ui/file_manager/video_player/js/video_player.js
[add] https://crrev.com/ef3d7d28a446c4ca7c13dbbe26cde907391d45f2/ui/file_manager/video_player/js/video_player_native_controls.js
[modify] https://crrev.com/ef3d7d28a446c4ca7c13dbbe26cde907391d45f2/ui/file_manager/video_player/js/video_player_scripts.js

Sign in to add a comment