New issue
Advanced search Search tips

Issue 909948 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Nov 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Investigate single-page tests for XR tests

Project Member Reported by bsheedy@chromium.org, Nov 29 
XR tests currently use testharness.js's async_test for all of its asserts. This makes it so the user has to wrap any asserts in a <test variable>.step() in order to work properly, which is both non-obvious to new users and adds bloat to the code.

I believe that testharness.js at some point added a way to specify that only one test would be run on a page, which removes the requirement of creating an async_test and wrapping asserts.

This bug is to track double checking that such functionality exists, and if so, whether it works correctly for XR tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ba5fa078528c932118478967e4d1cbf70c8f8e

commit 98ba5fa078528c932118478967e4d1cbf70c8f8e
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Nov 30 22:01:51 2018

Remove async_test from XR instrumentation

Removes use of testharness.js's async_test from all XR instrumentation
test files. testharness.js supports single-page tests, where not calling
test() or async_test() will allow asserts to work without having to be
wrapped in a step. This new approach is both cleaner and less confusing,
as it was not obvious to new users that asserts needed to be wrapped.

Bug:  909948 
Change-Id: If945571ef414953c538596da08976483ab39b3f9
Reviewed-on: https://chromium-review.googlesource.com/c/1356021
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612808}
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_device_capabilities_match_expectations.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_gamepad_button.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_nfc_fires_vrdisplayactivate.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_non_immersive_stops_during_immersive.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_payment_request.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_permissions_persist_when_entering_vr_browser.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_pose_data_unfocused_tab.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_presentation_locks_focus.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_presentation_promise_rejected_if_don_canceled.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_presentation_promise_unresolved_during_don.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_requestPresent_enters_vr.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_screen_taps_not_registered.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_select_tag.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_web_input_cursor_reposition.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_web_input_selection.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webvr_autopresent.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webvr_disabled_without_flag_set.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webvr_pixels.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webvr_reentry_from_vr_browser.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_capabilities.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_disabled_without_flag_set.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_does_not_return_device.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_gamepad_support.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_gamepad_support_nowebxr.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_input.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_pixels.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_poses.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_webxr_reentry_from_vr_browser.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_window_raf_fires_during_non_immersive_session.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_window_raf_fires_while_presenting.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/test_window_raf_stops_firing_while_presenting.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/webxr_test_pose_data_unfocused_tab.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/webxr_test_presentation_locks_focus.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/webxr_test_presentation_promise_rejected_if_don_canceled.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/webxr_test_presentation_promise_unresolved_during_don.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/webxr_test_screen_taps_not_registered.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/webxr_test_window_raf_fires_while_presenting.html
[modify] https://crrev.com/98ba5fa078528c932118478967e4d1cbf70c8f8e/chrome/test/data/xr/e2e_test_files/html/webxr_test_window_raf_stops_firing_during_immersive_session.html

Comment 2 by bsheedy@chromium.org, Nov 30

Status: Fixed (was: Assigned)
►

Sign in to add a comment