New issue
Advanced search Search tips

Issue 909937 link

Starred by 3 users
Status: Started
Owner:
aaronhk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Heuristics for determining unaccelerated vs accelerated canvases could likely be improved.

Project Member Reported by aaronhk@chromium.org, Nov 29 
Currently we guess whether a canvas should be unaccelerated (CPU RAM) or accelerated (GPU RAM) based on size and assumed use. With new performance tests in place it is possible to more accurately determine when unaccelerated canvases are actually more performant.
Showing comments 49 - 148 of 148 Older ›
Project Member

Comment 50 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14999ad4140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\it8f9pee\\tmp_ry_sqtelemetry\\histograms.json'
Project Member

Comment 51 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11e89522140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itvxoikf\\tmp3ns1gdtelemetry\\histograms.json'
Project Member

Comment 52 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13cf0f9c140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 53 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11738c32140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 54 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11be9418140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 55 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1702164c140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itL2THzI/tmpBzoM_Ctelemetry/histograms.json'
Project Member

Comment 56 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1302164c140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 57 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13b509d2140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itfcJ0Vt/tmpfZsClmtelemetry/histograms.json'
Project Member

Comment 68 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/10f9465a140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 70 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/131960d4140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 71 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14be5d16140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\it9i4utp\\tmp5r5iv1telemetry\\histograms.json'
Project Member

Comment 72 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/109960d4140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itjupdqw\\tmprz_gcztelemetry\\histograms.json'
Project Member

Comment 73 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14db1aca140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\it4ldtsi\\tmpo1rkkjtelemetry\\histograms.json'
Project Member

Comment 74 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16955bc4140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itju8ewp\\tmpfhrpvetelemetry\\histograms.json'
Project Member

Comment 76 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11ca4f4a140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 77 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14d5d218140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itskCYUm/tmpS7VcSDtelemetry/histograms.json'
Project Member

Comment 78 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14e86abc140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itUWje_I/tmpv8m4Pttelemetry/histograms.json'
Project Member

Comment 79 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12b6940a140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itLGVl52/tmpYWT8WStelemetry/histograms.json'
Project Member

Comment 80 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14c568f4140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
Project Member

Comment 81 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/148510da140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 82 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12e14c9c140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
Project Member

Comment 83 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1236ecd4140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 84 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16e89522140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
Project Member

Comment 85 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/15ca4f4a140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 86 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/130dc7d2140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 87 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12d6c112140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itf15lz1\\tmpdozdtatelemetry\\histograms.json'
Project Member

Comment 89 by 42576172...@developer.gserviceaccount.com, Dec 8 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/145efdd8140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itpzclzf\\tmpyqm3tttelemetry\\histograms.json'
Project Member

Comment 90 by 42576172...@developer.gserviceaccount.com, Dec 9 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12defdd8140000
Project Member

Comment 104 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14ff6d36140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
Project Member

Comment 105 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/15d55bc4140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
Project Member

Comment 106 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14e40b22140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itzmfnde\\tmpfekdrmtelemetry\\histograms.json'
Project Member

Comment 107 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/146dc7d2140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itjqh7do\\tmp9vrz3htelemetry\\histograms.json'
Project Member

Comment 108 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14e7160a140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/it1Zg5D0/tmpfYSwpitelemetry/histograms.json'
Project Member

Comment 109 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/10d960d4140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itti6ZoZ/tmpjyakfJtelemetry/histograms.json'
Project Member

Comment 110 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1289c5f8140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/swarming/w/it_SFwpq/tmpd3Mpk8telemetry/histograms.json'
Project Member

Comment 111 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/15ba089c140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/swarming/w/itP10S9e/tmpMD8wiQtelemetry/histograms.json'
Project Member

Comment 112 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14cb827a140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/swarming/w/it1N27ka/tmplnwktPtelemetry/histograms.json'
Project Member

Comment 113 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14ccfa18140000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\it1dtgpm\\tmptl_fqutelemetry\\histograms.json'
Project Member

Comment 114 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14d53b16140000
Project Member

Comment 115 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/17b5019c140000
Project Member

Comment 116 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/11ba089c140000
Project Member

Comment 118 by 42576172...@developer.gserviceaccount.com, Dec 10 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11f5019c140000

All of the runs failed. The most common error (20/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.
Project Member

Comment 133 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14ae9cda140000
Project Member

Comment 134 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/1495336a140000
Project Member

Comment 135 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14fb4dd2140000
Project Member

Comment 136 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/116f0f9c140000
Project Member

Comment 137 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/170aa4f4140000
Project Member

Comment 138 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/13ff6d36140000
Project Member

Comment 139 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/120d019c140000
Project Member

Comment 140 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/129176f4140000
Project Member

Comment 141 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/159a4f4a140000
Project Member

Comment 142 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/17cacaac140000
Project Member

Comment 143 by 42576172...@developer.gserviceaccount.com, Dec 10 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/15ff6d36140000
Project Member

Comment 144 by 42576172...@developer.gserviceaccount.com, Dec 11 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/10b55bc4140000
Project Member

Comment 145 by 42576172...@developer.gserviceaccount.com, Dec 12 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/1788f4f4140000
Project Member

Comment 147 by 42576172...@developer.gserviceaccount.com, Dec 14 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13d8828e140000

All of the runs failed. The most common error (20/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
Project Member

Comment 148 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2f827d422c1e0ff6b26717f1afecd1bd44266fc

commit f2f827d422c1e0ff6b26717f1afecd1bd44266fc
Author: Aaron Krajeski <aaronhk@google.com>
Date: Tue Jan 08 15:08:34 2019

Create a finch trial to always accelerate canvases.

Currently there's a lot of logic dictating whether
canvases use CPU ram or VRAM (non-accelerated or
accelerated). With new perf tests and UMA metrics we
can now experimentally test which is better. A doc
with data and more detail can be found here:
https://docs.google.com/document/d/11Xsse3Z-EBv5B-_tYfPEzh3qUW9CuTiHO4pJTz78TfA/edit#

With the flag a bunch of layout tests fail due to
anti-aliasing differences.

Bug: 909937
Change-Id: I18f89564f5c7dfffbe65bd896e6f4f52fa326873
Reviewed-on: https://chromium-review.googlesource.com/c/1371937
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620724}
[modify] https://crrev.com/f2f827d422c1e0ff6b26717f1afecd1bd44266fc/third_party/blink/common/features.cc
[modify] https://crrev.com/f2f827d422c1e0ff6b26717f1afecd1bd44266fc/third_party/blink/public/common/features.h
[modify] https://crrev.com/f2f827d422c1e0ff6b26717f1afecd1bd44266fc/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/f2f827d422c1e0ff6b26717f1afecd1bd44266fc/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/f2f827d422c1e0ff6b26717f1afecd1bd44266fc/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/f2f827d422c1e0ff6b26717f1afecd1bd44266fc/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/f2f827d422c1e0ff6b26717f1afecd1bd44266fc/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
Showing comments 49 - 148 of 148 Older ›
►

Sign in to add a comment