New issue
Advanced search Search tips

Issue 909893 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Provide recipe information in go/build-proto

Project Member Reported by no...@chromium.org, Nov 28

Issue description

Milo would like to display a link to the recipe used by the build.
We need to surface that info at the build proto level.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f4cbaa91dc2a1c8a79f77ce899b6505e4b49fd4f

commit f4cbaa91dc2a1c8a79f77ce899b6505e4b49fd4f
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Nov 29 18:39:08 2018

[buildbucket] Add recipe info to build proto

Milo would like to provide a link to the recipe used for a build.
Record the recipe cipd package and recipe name, coming from cr-buildbucket.cfg
This info will end up in BQ available for analysis.

This does not provide the source code location (buildbucket doesn't have it
anyway), but we could attach source code info to the CIPD package instance.
Then Milo could load that.

Later we can also add requested/actual CIPD version.

R=iannucci@chromium.org, vadimsh@chromium.org

Bug:  909893 
Change-Id: I56346cd6da15d9e5f16e1c1daa6f0f1a0eee28d9
Reviewed-on: https://chromium-review.googlesource.com/c/1354093
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/f4cbaa91dc2a1c8a79f77ce899b6505e4b49fd4f/buildbucket/proto/build.pb.go
[modify] https://crrev.com/f4cbaa91dc2a1c8a79f77ce899b6505e4b49fd4f/buildbucket/proto/build.proto
[modify] https://crrev.com/f4cbaa91dc2a1c8a79f77ce899b6505e4b49fd4f/buildbucket/proto/pb.discovery.go

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b0a38f975312e63f9038642952c1e2e9359f1253

commit b0a38f975312e63f9038642952c1e2e9359f1253
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Dec 03 19:07:00 2018

[buildbucket] Populate recipe info

Add recipe-specific properties to the Build entity.
Later we may simplify this when buildbucket has less responsibilities.

Bug:  909893 
Change-Id: I3e2cdabd291ceffd955d63ffd41329aef1798459
Reviewed-on: https://chromium-review.googlesource.com/c/1357199
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19293}
[modify] https://crrev.com/b0a38f975312e63f9038642952c1e2e9359f1253/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/b0a38f975312e63f9038642952c1e2e9359f1253/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/b0a38f975312e63f9038642952c1e2e9359f1253/appengine/cr-buildbucket/v2/test/builds_test.py
[modify] https://crrev.com/b0a38f975312e63f9038642952c1e2e9359f1253/appengine/cr-buildbucket/model.py
[modify] https://crrev.com/b0a38f975312e63f9038642952c1e2e9359f1253/appengine/cr-buildbucket/v2/builds.py

Sign in to add a comment