New issue
Advanced search Search tips

Issue 909871 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 29
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

svg/.../svg-fonts-in-text-controls.html in webkit_layout_tests failing on chromium.win/WebKit Win10

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 28

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rockot@google.com

svg/.../svg-fonts-in-text-controls.html in webkit_layout_tests failing on chromium.win/WebKit Win10

Builders failed on: 
- WebKit Win10: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10


 
Owner: yosin@chromium.org
This broke at https://chromium-review.googlesource.com/c/chromium/src/+/1350443

Please take a look, as it's not clear to me why it's only broken on Win10?
Status: Started (was: Available)
I forgot to update platform/win test expectation in the CL[1].

There are five test expectations for svg-fonts-in-text-controls.html:
 1. generic
 2. win (for Win10); forgot to update
 3. win7
 4. mac
 5. linux

I'll update the test expectation.

[1] http://crrev.com/c/1350443 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText
Committing... http://crrev.com/c/1354719
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2efbf9e286d64777113c5f69481ba4aa8cbc7989

commit 2efbf9e286d64777113c5f69481ba4aa8cbc7989
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Nov 29 04:42:49 2018

Update web test expectation for svg/custom/svg-fonts-in-text-controls.html for Windows

This updates web test expectation for "svg-fonts-in-text-controls.html" for
Windows platform, chromium.win/WebKit Win10 bot.

This patch is a follow-up the CL[1] which missed to update this expectation.

[1] http://crrev.com/c/1350443 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText

TBR=rockot@google.com

Bug:  909871 
Change-Id: I509a305e7f17bbb07c9a72ce32f1edc281a2eb85
Reviewed-on: https://chromium-review.googlesource.com/c/1354719
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612039}
[modify] https://crrev.com/2efbf9e286d64777113c5f69481ba4aa8cbc7989/third_party/blink/web_tests/platform/win/svg/custom/svg-fonts-in-text-controls-expected.txt

Status: Fixed (was: Started)
Let's see chromium.WebKit Win10 bot will be green.
Labels: -Sheriff-Chromium
Status: Verified (was: Fixed)
Mark Verified

The patch is in build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/43514

Sign in to add a comment