New issue
Advanced search Search tips

Issue 909863 link

Starred by 1 user
Status: Assigned
Owner:
pcovell@chromium.org
Cc:
tranbao...@chromium.org
iloahz@chromium.org
shend@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Ctrl+Space does not work as expected with 3 keyboard layouts (input methods) set

Project Member Reported by dimitry@google.com, Nov 28 
Chrome Version: 70.0.3538.76 (Official Build) (64-bit)
OS: ChromeOS

What steps will reproduce the problem?
(1) Set up 3 languages (EN, DE, RU in my case)
(2) Try switching between them by holding ctrl and pressing space several times

What is the expected result?
It switches between 3 languages RU -> US -> DE -> RU -> ... 

What happens instead?
It switches between 2 last used languages US -> DE -> US -> DE ...

Comment 1 by dtapu...@chromium.org, Nov 30

Components: UI>Input>Text>IME

Comment 2 by shend@chromium.org, Dec 3

Cc: iloahz@chromium.org
Owner: shend@chromium.org
Status: Assigned (was: Untriaged)
Hi I believe this is WAI. Ctrl-space should swap between most recent 2. Ctrl-shift-space should cycle through all languages.

However, I believe this is inconsistent with system settings documentation. We should update it.

Comment 3 by iloahz@chromium.org, Dec 3 

The doc is at:

Settings -> Device#Keyboard -> View keyboard shortcuts -> System & Display Settings.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54c3aef61f7f6568ff4c4f1526107d9894003c94

commit 54c3aef61f7f6568ff4c4f1526107d9894003c94
Author: Darren Shen <shend@chromium.org>
Date: Fri Dec 07 04:43:11 2018

[VK] Fix keyboard shortcut documentation.

This patch fixes the ambiguous description in the keyboard shortcut
viewer for Ctrl-Space and Ctrl-Shift-Space. Namely, Ctrl-Space
toggles between the current input method and the last used, whereas
Ctrl-Shift-Space cycles through all of them. The naming is confusing
because "previous" here means "last used" and not the opposite of
"next". The two shortcuts are -not- inverses of each other. We rename
the implementation as well for clarity.

TBR=shuchen@chromium.org

Bug: 909863
Change-Id: I7ca8d70d5d571ce3065814cb789e79a1488b875d
Reviewed-on: https://chromium-review.googlesource.com/c/1358195
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614603}
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/accelerators/accelerator_table.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/accelerators/accelerator_table_unittest.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/components/shortcut_viewer_strings.grdp
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/ime/ime_controller.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/ime/ime_controller.h
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/ime/ime_controller_unittest.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/ime/test_ime_controller_client.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/ime/test_ime_controller_client.h
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/public/cpp/accelerators.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/public/cpp/accelerators.h
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ash/public/interfaces/ime_controller.mojom
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/chrome/browser/chromeos/input_method/input_method_manager_impl.h
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/chrome/browser/ui/ash/ime_controller_client.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/chrome/browser/ui/ash/ime_controller_client.h
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/chrome/browser/ui/ash/ime_controller_client_unittest.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ui/base/ime/chromeos/input_method_manager.h
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ui/base/ime/chromeos/mock_input_method_manager.cc
[modify] https://crrev.com/54c3aef61f7f6568ff4c4f1526107d9894003c94/ui/base/ime/chromeos/mock_input_method_manager.h

Comment 5 by shend@chromium.org, Dec 7

Cc: tranbao...@chromium.org shend@chromium.org
Labels: -Type-Bug Type-Feature
Owner: pcovell@chromium.org
The documentation is fixed, but I'm going to turn this into a feature request.

Paraphrasing tranbaoduy@: intuitively Ctrl-Space and Ctrl-Shift-Space should be a pair and do opposite actions. So we should evaluate changing both shortcuts to cycle through all input methods, but in different directions.

This is what OS X does.
►

Sign in to add a comment