New issue
Advanced search Search tips

Issue 909854 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: 2
NextAction: ----
OS: ----
Pri: 1
Type: Feature


Show other hotlists

Hotlists containing this issue:
CrOSParallelCQ


Sign in to add a comment

CQ: skip a builder in dryrun

Project Member Reported by no...@chromium.org, Nov 28

Issue description

CrOS would like to skip expensive HWTests in CQ dryrun. 
HWTests is step(s) in a pre-submit builder, so we'd need to pass the dryrun flag to the build, perhaps as a property.

FWIU this should be a non-default behavior, otherwise by default we cannot reuse a dry build for a non-dry run. Perhaps we need a builder-level setting in cq.cfg to pass the flag.

This blocks CrOS adoption of CQ.

assigning to triage.
 
also note that CrOS is fine redoing the work that was already done in a dry build because it takes much less time than HWTest.
Also note that HWTests are present in many builders and moving them out to a separate set of hw builders would be complicated, especially for a short term solution.
Summary: CQ: skip a builder in dryrun (was: Add a dryrun property)
after chatting more, we figured that it would be simpler to do the following instead:
- have two variants of each builder: hw and non-hw. They are independent and no reuse each other's work.
- CQ skips hw in dryrun

it is better because a green build of builder X clearly says whether HW were included. Gerrit wouldn't combine hw and non-hw builds into one block.

so looks like instead we just need a per-builder boolean flag in cq.cfg that instructs CQ to skip the builder in dryrun mode.
I like this idea, perhaps a dry run enum with values:
  ALSO // default, means also run in dry run
  SKIP // skips in dry run, but runs in full run.
  ONLY // only run during dry run.

Btw, you logic about UI also applies to special presubmit builders, which do different things during dry run.
EstimatedDays: 2

Sign in to add a comment