New issue
Advanced search Search tips

Issue 909848 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature


Sign in to add a comment

Convert Recipe Engine to build.proto

Project Member Reported by iannu...@google.com, Nov 28

Issue description

This is a high-level tracking bug for converting the recipe engine's state export from the old @@@annotation@@@ protocol to https://chromium.googlesource.com/infra/luci/luci-go/+/master/buildbucket/proto/build.proto.

Design doc (internal for boring reasons. If you really wanna see this, lmk and I'll do the work to make it public): https://docs.google.com/document/d/18pocsC3aeLoW3MzQ2smvBgs7nSYEBsTM-dY9QV_iLCg/edit#

The relevant bits of the doc are the rollout plan:
  * Make new recipe which runs quickly and exercises 100% of presentation API
  * Add 2 builders (FYI / UI / annotator, FYI / UI / build.proto) each on -dev and prod which run this recipe on a 10m cron.
  * Introduce swarming tag which activates
    * build.proto rendering logic on milo
    * build.proto logic in kitchen
    * build.proto logic in recipes
  * Set this tag on the "build.proto" variants.
  * Pay off a bit of debt by simplifying kitchen (only 'cook_logdog' is actually used in practice)
  * Hack on milo/kitchen/recipes under this flag to make the new path work. (this step will be expanded when we get to it)
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/d0deba23a671b236ec535a9a54aa78b6dcf142ab

commit d0deba23a671b236ec535a9a54aa78b6dcf142ab
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 29 18:53:16 2018

[Testing] Add comprehensive UI test recipe.

This will be used to exercise the full milo/buildbucket/kitchen/recipe_engine
stack w.r.t. build.proto streaming.

Recipe is still missing some features, but I want to get the baseline in
so I can set up builders, etc. ASAP.

R=hinoka@chromium.org, jchinlee@chromium.org

Bug: 909848
Change-Id: I4944c06d2578fd0af0a1815c3bde9b6b7c669cb2
Reviewed-on: https://chromium-review.googlesource.com/c/1354247
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[add] https://crrev.com/d0deba23a671b236ec535a9a54aa78b6dcf142ab/recipes/engine_tests/comprehensive_ui.expected/basic.json
[modify] https://crrev.com/d0deba23a671b236ec535a9a54aa78b6dcf142ab/README.recipes.md
[add] https://crrev.com/d0deba23a671b236ec535a9a54aa78b6dcf142ab/recipes/engine_tests/comprehensive_ui.py

Blocking: 910369
Blockedon: 913102
Cc: estaab@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 11

Labels: merge-merged-config
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/f77e7144ebbd764c74d4cd8820341b0b8734b99b

commit f77e7144ebbd764c74d4cd8820341b0b8734b99b
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Dec 11 02:13:58 2018

Blockedon: 914196
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/534c871a701c1db1eee18c1cb83667347cf1fa80

commit 534c871a701c1db1eee18c1cb83667347cf1fa80
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Dec 12 01:53:27 2018

[build.proto] Add new comprehensive ui test builders to -dev

R=nodir@chromium.org

Bug: 909848
Change-Id: I57405e9bcf10e89da7edcb360dca5483ed9c392f
Reviewed-on: https://chromium-review.googlesource.com/c/1372812
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/534c871a701c1db1eee18c1cb83667347cf1fa80/luci-scheduler-dev.cfg
[modify] https://crrev.com/534c871a701c1db1eee18c1cb83667347cf1fa80/cr-buildbucket-dev.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/b1a0988216d85023baa79c88d10e81954d656f06

commit b1a0988216d85023baa79c88d10e81954d656f06
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Dec 12 05:25:36 2018

[build.proto-dev] Switch to Chrome pool

TBR=nodir@chromium.org

Bug: 909848
Change-Id: I2e9dc022f914734867bcfe506066c073e72f5d75
Reviewed-on: https://chromium-review.googlesource.com/c/1373269
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/b1a0988216d85023baa79c88d10e81954d656f06/cr-buildbucket-dev.cfg

Blocking: 914268
Blockedon: 914629
Blockedon: 914630
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/4e2a492ca556e8dc991b52f0a3b683619af809a4

commit 4e2a492ca556e8dc991b52f0a3b683619af809a4
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Dec 14 20:54:40 2018

[protobuf] Update to protobuf 3.6.0.

R=nodir@chromium.org

Bug: 909848
Change-Id: I617b5a60e4b535f1490f7189d623defb4ad866a1
Reviewed-on: https://chromium-review.googlesource.com/c/1374377
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/result_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/package.proto
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/test_result_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/doc_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/source_manifest_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/package_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/arguments_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/analyze_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/annotations_pb2.py
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/recipe_engine/source_manifest.proto
[modify] https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4/.vpython

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7e79cc11f88de68b41dff4d7985cf415ce590788

commit 7e79cc11f88de68b41dff4d7985cf415ce590788
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Dec 20 04:35:44 2018

Refactor dockerbuild.

This makes all 'Builder' objects actually separate types.

It also enforces some (minimal) sorting/organization of wheel.py, and
adds some additional documentation there for what each kind of wheel
declaration actually is.

Makes behavior of 'special' builders a bit more obvious (as the 'build_fn'
is now encapsulated in that special Builder type so the scope of the
function and its responsibilities are better understood. That said,
'build_fn' still has a pretty weird signature, but one thing at a time...)

R=hinoka@chromium.org, tandrii@chromium.org

Change-Id: I2c04c60ad2c3ee091b7dce37512368f11d2bba76
Bug: 909848
Reviewed-on: https://chromium-review.googlesource.com/c/1381261
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19686}
[modify] https://crrev.com/7e79cc11f88de68b41dff4d7985cf415ce590788/infra/tools/dockerbuild/wheel.py
[modify] https://crrev.com/7e79cc11f88de68b41dff4d7985cf415ce590788/infra/tools/dockerbuild/wheel_opencv.py
[modify] https://crrev.com/7e79cc11f88de68b41dff4d7985cf415ce590788/infra/tools/dockerbuild/wheel_infra.py
[modify] https://crrev.com/7e79cc11f88de68b41dff4d7985cf415ce590788/infra/tools/dockerbuild/builder.py
[modify] https://crrev.com/7e79cc11f88de68b41dff4d7985cf415ce590788/infra/tools/dockerbuild/wheel_wheel.py
[modify] https://crrev.com/7e79cc11f88de68b41dff4d7985cf415ce590788/infra/tools/dockerbuild/wheel_mysql.py
[modify] https://crrev.com/7e79cc11f88de68b41dff4d7985cf415ce590788/infra/tools/dockerbuild/wheel_cryptography.py

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/06fca90611a9dedcf831ccc9468513d3802842ec

commit 06fca90611a9dedcf831ccc9468513d3802842ec
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Dec 20 20:44:48 2018

[dockerbuild] Add argparse wheel.

This is needed for the recipe engine.

Bug: 909848
Change-Id: I0c3eee61eae73dcfecc81874a9a128935d7e928e
Reviewed-on: https://chromium-review.googlesource.com/c/1385676
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19691}
[modify] https://crrev.com/06fca90611a9dedcf831ccc9468513d3802842ec/infra/tools/dockerbuild/wheel.py
[modify] https://crrev.com/06fca90611a9dedcf831ccc9468513d3802842ec/infra/tools/dockerbuild/wheels.md

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e5a9b06e1ea5e79e15552c3ed22d584f50d961dc

commit e5a9b06e1ea5e79e15552c3ed22d584f50d961dc
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Dec 20 22:00:11 2018

[dockerbuild] Add protobuf 3.6.1

Needed so that recipe engine can have a consistent version of protoc and
protobuf library (since the current `protoc` version is actually 3.6.1)

R=jchinlee@chromium.org, tandrii@chromium.org

Bug: 909848, 914992
Change-Id: I419a8410fb6d8d4ac0fe6dcbad619bd9ee0de5e6
Reviewed-on: https://chromium-review.googlesource.com/c/1385677
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19692}
[modify] https://crrev.com/e5a9b06e1ea5e79e15552c3ed22d584f50d961dc/infra/tools/dockerbuild/wheel.py
[modify] https://crrev.com/e5a9b06e1ea5e79e15552c3ed22d584f50d961dc/infra/tools/dockerbuild/wheels.md

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/d4166b614aaea6fd574864a6b16b0363156a1720

commit d4166b614aaea6fd574864a6b16b0363156a1720
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Jan 11 20:58:49 2019

Remove unused emit_timestamp flag.

Nothing uses this (on buildbot or LUCI).

One step closer to removing `arguments.proto` entirely.

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Change-Id: I27c9542724be561083f7db35a41897ac7db49a85
Bug: 909848
Reviewed-on: https://chromium-review.googlesource.com/c/1404678
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/d4166b614aaea6fd574864a6b16b0363156a1720/recipe_engine/arguments_pb2.py
[modify] https://crrev.com/d4166b614aaea6fd574864a6b16b0363156a1720/recipe_engine/run.py
[modify] https://crrev.com/d4166b614aaea6fd574864a6b16b0363156a1720/recipe_engine/arguments.proto

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d8f38ca9494b5af249942631f9cee45927f6b4bc

commit d8f38ca9494b5af249942631f9cee45927f6b4bc
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Jan 11 22:09:03 2019

[kitchen] Remove use of --operational-arguments-path entirely.

Depends on https://chromium-review.googlesource.com/1404679 being
deployed everywhere.

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug: 909848
Change-Id: Iaaa6d8fc5ac40551082947e115b7ff30ccad9b76
Reviewed-on: https://chromium-review.googlesource.com/c/1404718
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19944}
[delete] https://crrev.com/00f07b5a51a1fb2ff3f5651d36bb678dde3f92fb/go/src/infra/tools/kitchen/third_party/recipe_engine/arguments.proto
[modify] https://crrev.com/d8f38ca9494b5af249942631f9cee45927f6b4bc/go/src/infra/tools/kitchen/cook_test.go
[delete] https://crrev.com/00f07b5a51a1fb2ff3f5651d36bb678dde3f92fb/go/src/infra/tools/kitchen/third_party/recipe_engine/arguments.pb.go
[modify] https://crrev.com/d8f38ca9494b5af249942631f9cee45927f6b4bc/go/src/infra/tools/kitchen/recipe.go
[modify] https://crrev.com/d8f38ca9494b5af249942631f9cee45927f6b4bc/go/src/infra/tools/kitchen/testdata/recipe_repo/recipes.py
[modify] https://crrev.com/d8f38ca9494b5af249942631f9cee45927f6b4bc/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/d8f38ca9494b5af249942631f9cee45927f6b4bc/go/src/infra/tools/kitchen/cook_logdog.go

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/53e9006fc399f37445a3b3a3ec4779eb3ce3306f

commit 53e9006fc399f37445a3b3a3ec4779eb3ce3306f
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Jan 11 23:01:29 2019

Remove use of op_args.annotation_flags.emit_initial_properties.

This will allow us to fully remove 'arguments.proto'.

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug: 909848
Change-Id: I8f86ffd3a057941959e052ee556a8ad6182d5e37
Reviewed-on: https://chromium-review.googlesource.com/c/1404679
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/53e9006fc399f37445a3b3a3ec4779eb3ce3306f/recipe_engine/run.py
[modify] https://crrev.com/53e9006fc399f37445a3b3a3ec4779eb3ce3306f/recipe_engine/arguments.proto

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 12

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b0602658afeb1d02b4a0b324069119fdf5777475

commit b0602658afeb1d02b4a0b324069119fdf5777475
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Jan 12 00:05:58 2019

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 12

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/78936430c90e535d92b72ffe36f7aa2860b3ad48

commit 78936430c90e535d92b72ffe36f7aa2860b3ad48
Author: Robbie Iannucci <iannucci@google.com>
Date: Sat Jan 12 03:40:55 2019

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/21bc41b7f523ccc371e84bce0f4d5dccfb85d48a

commit 21bc41b7f523ccc371e84bce0f4d5dccfb85d48a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jan 15 01:27:02 2019

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/feda358a66696ce4d784e587c3445231e8b652b0

commit feda358a66696ce4d784e587c3445231e8b652b0
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jan 15 01:45:42 2019

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/95d0969d10a781a809c1cb23444e5c8441cf25a2

commit 95d0969d10a781a809c1cb23444e5c8441cf25a2
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jan 15 20:36:52 2019

Remove kitchen from everything.

The vast majority of the remaining buildbot builders use regular
remote_run. There's more harm than good in having the 'kitchen' mode
at this point. Users should switch off buildbot, but until then remote_run
should behave consistently.

I'll remove other vestiges of kitchen in a subsequent CL.

R=mmoss@chromium.org, nodir@chromium.org, tandrii@chromium.org

Bug: 909848
Change-Id: I1cf3479fa0f74ad38a96d967cbaf692c0fd33fee
Reviewed-on: https://chromium-review.googlesource.com/c/1413036
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/95d0969d10a781a809c1cb23444e5c8441cf25a2/scripts/slave/remote_run.py

Project Member

Comment 26 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/2f65b24e319f41a6009c857b1928cb2f7aea9c45

commit 2f65b24e319f41a6009c857b1928cb2f7aea9c45
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Jan 15 22:23:19 2019

Remove env, unused third party dependencies.

R=hinoka@chromium.org, tandrii@chromium.org

Change-Id: I5224684a85d1205ea77a997951dbbcd9e6917fb3
Bug: 909848
Reviewed-on: https://chromium-review.googlesource.com/c/1381471
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[rename] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/logdog/OWNERS
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/common_args.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/subprocess42.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/unittests/gitattr_checker_test.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/arfile/__init__.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/arfile/arfile_test.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/stream.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/logdog/tests/bootstrap_test.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/unittests/test_test.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/unittests/analyze_test.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/README.argparse
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/doc.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/checker.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/arfile/arfile.py
[rename] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/logdog/stream.py
[rename] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/logdog/varint.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/env.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/README.recipes.md
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/step_runner.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/main.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/unittests/fetch_test.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/autoroll.py
[rename] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/logdog/bootstrap.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/depgraph.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/unittests/test_env.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/unittests/autoroll_test.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/argparse.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/loader.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/luci_context/__init__.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/luci_context/luci_context.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/logdog/tests/stream_test.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/luci_context/OWNERS
[rename] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/logdog/__init__.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/autoroll_impl/unittests/test_env.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/analyze.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/arfile/cli.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/.vpython
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/fetch.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/test.py
[rename] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/__init__.py
[rename] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/logdog/streamname.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/manual_roll.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/unittests/repo_test_util.py
[add] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/third_party/README.md
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/doc_markdown.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/luci_context/luci_context_test.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/logdog/tests/streamname_test.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/package_io.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/unittests/loader_test.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/run.py
[delete] https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b/recipe_engine/third_party/client-py/libs/logdog/tests/varint_test.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/package.py
[modify] https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45/recipe_engine/recipe_api.py

Project Member

Comment 27 by bugdroid1@chromium.org, Jan 16 (6 days ago)

Project Member

Comment 28 by bugdroid1@chromium.org, Jan 16 (6 days ago)

Sign in to add a comment