New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 909836 link

Starred by 1 user
Status: Assigned
Owner:
erikc...@chromium.org
Cc:
█ nednguyen@chromium.org
martiniss@chromium.org
jbudorick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

'retry with patch' and 'retry without patch' should set --test-launcher-batch-limit=1

Project Member Reported by erikc...@chromium.org, Nov 28 
This forces the gtest harness to use a separate process for each test, which reduces flakiness caused by state carrying over between tests. We don't normally run with this flag because it slows down the tests by 4-10X. However, since we only expect to be retrying a small subset of all tests, the slowdown seems worth it.

Comment 1 by jbudorick@chromium.org, Nov 28 

this sounds reasonable as long as we gate it on having a relatively small number of tests to retry, along the lines of https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/steps.py?rcl=803f9d5158ec63ecbb8f73ec6b5fcfb852e2d9c4&l=121
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bd261424c727962e7c51643f0746e81109c4bbe7

commit bd261424c727962e7c51643f0746e81109c4bbe7
Author: erikchen <erikchen@chromium.org>
Date: Fri Nov 30 15:55:32 2018

Force independent retries for GTest based test suites.

When a small number of tests are being retried, we set
--test-launcher-batch-limit=1 to force the retries to be run in independent
processes.

Bug: 909836
Change-Id: Id27587492f36e8bcaeef5588576bf58b650b951c
Reviewed-on: https://chromium-review.googlesource.com/c/1351697
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_invalid_test_results.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_affected_files.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_gtest_test.expected/android.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_gtest_test.expected/retry.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_recipes.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_gtest_test.expected/basic.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
►

Sign in to add a comment