New issue
Advanced search Search tips

Issue 909827 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Direct composition code cleanup

Project Member Reported by sunn...@chromium.org, Nov 28

Issue description

Four cleanups planned:
1) Cleanup overlay param struct and remove unnecessary shared state (crrev.com/1292515)
2) Move direct composition surface from gpu/ipc/service to ui/gl
3) Move ProtectedVideoType to ui/gfx so that viz/common doesn't need to
   depend on ui/gl
4) Split direct composition surface and its helpers
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035

commit 4f92c86588b2cc2c1e3ef9bbe2897269cda3f035
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Tue Dec 04 03:28:36 2018

Cleanup DC overlay parameters

Remove extraneous parameters and remove the unnecessary shared state
split.  Add documentation for each parameter.

Followup cleanup planned:
1) Move direct composition surface from gpu/ipc/service to ui/gl
2) Move ProtectedVideoType to ui/gfx so that viz/common doesn't need to
   depend on ui/gl
3) Split direct composition surface and its helpers

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I507209d66229183dc00c3039b9e2db7629f39d14
Bug: 909827
Reviewed-on: https://chromium-review.googlesource.com/c/1292515
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613411}
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/components/viz/service/display/dc_layer_overlay.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/components/viz/service/display/dc_layer_overlay.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/gles2_cmd_buffer_functions.txt
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gl_utils.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/gpu/ipc/service/direct_composition_surface_win_unittest.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/ui/gl/dc_renderer_layer_params.cc
[modify] https://crrev.com/4f92c86588b2cc2c1e3ef9bbe2897269cda3f035/ui/gl/dc_renderer_layer_params.h

Sign in to add a comment