Issue metadata
Sign in to add a comment
|
Flakiness in ClearSiteDataHandlerBrowserTest.ClosedTab caused by network service. |
||||||||||||||||||||||||
Issue descriptionOn this unrelated CL: https://chromium-review.googlesource.com/c/chromium/src/+/1347354/4 network_service_content_browsertests failed multiple times: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10_chromium_x64_rel_ng/143365 but succeeded on retry: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10_chromium_x64_rel_ng/143422 """ DevTools listening on ws://127.0.0.1:64185/devtools/browser/f04f25ee-305d-41c1-b398-076f872a9444 [1392:1336:1121/140256.188:FATAL:network_service.mojom.cc(3385)] Check failed: !connected. NetworkServiceClient::OnClearSiteDataCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe. Backtrace: base::debug::StackTrace::StackTrace [0x00007FF7B4C88F94+36] logging::LogMessage::~LogMessage [0x00007FF7B4CA2242+98] network::mojom::NetworkServiceClient_OnClearSiteData_ProxyToResponder::OnIsConnectedComplete [0x00007FF7B2BAD7D3+147] base::OnceCallback<void __cdecl(bool)>::Run [0x00007FF7B249E359+57] base::internal::OptionalStorageBase<mojo::DisconnectReason,0>::Init<mojo::DisconnectReason const & __ptr64> [0x00007FF7B4B5D10D+1389] base::internal::OptionalStorageBase<mojo::DisconnectReason,0>::Init<mojo::DisconnectReason const & __ptr64> [0x00007FF7B4B5D017+1143] network::mojom::NetworkServiceClient_OnClearSiteData_ProxyToResponder::~NetworkServiceClient_OnClearSiteData_ProxyToResponder [0x00007FF7B2BAD6EE+110] std::unique_ptr<network::mojom::NetworkServiceClient_OnClearSiteData_ProxyToResponder,std::default_delete<network::mojom::NetworkServiceClient_OnClearSiteData_ProxyToResponder> >::~unique_ptr<network::mojom::NetworkServiceClient_OnClearSiteData_ProxyToRes [0x00007FF7B2BAD575+21] base::internal::BindState<void (__cdecl network::mojom::NetworkServiceClient_OnClearSiteData_ProxyToResponder::*)(void) __ptr64,std::unique_ptr<network::mojom::NetworkServiceClient_OnClearSiteData_ProxyToResponder,std::default_delete<network::mojom::Netwo [0x00007FF7B2BAD656+22] base::internal::BindState<void (__cdecl*)(base::TimeTicks,std::unique_ptr<content::ClearSiteDataHandler::ConsoleMessagesDelegate,std::default_delete<content::ClearSiteDataHandler::ConsoleMessagesDelegate> >,base::RepeatingCallback<content::WebContents * _ [0x00007FF7B3791B96+54] content::ClearSiteDataHandler::ExecuteClearingTask [0x00007FF7B37911CE+894] content::ClearSiteDataHandler::Run [0x00007FF7B3790C76+550] content::ClearSiteDataHandler::HandleHeaderAndOutputConsoleMessages [0x00007FF7B37904CE+14] content::ClearSiteDataHandler::HandleHeader [0x00007FF7B379030B+155] content::NetworkServiceClient::OnClearSiteData [0x00007FF7B39F4660+224] network::mojom::NetworkServiceClientStubDispatch::AcceptWithResponder [0x00007FF7B2B9EFD8+2072] network::mojom::NetworkServiceClientStub<mojo::RawPtrImplRefTraits<network::mojom::NetworkServiceClient> >::AcceptWithResponder [0x00007FF7B2AD091A+58] mojo::InterfaceEndpointClient::HandleValidatedMessage [0x00007FF7B4B5B0A1+641] mojo::FilterChain::Accept [0x00007FF7B56A95E7+151] mojo::InterfaceEndpointClient::HandleIncomingMessage [0x00007FF7B4B5C1DA+122] mojo::internal::MultiplexRouter::ProcessIncomingMessage [0x00007FF7B4B60107+727] mojo::internal::MultiplexRouter::Accept [0x00007FF7B4B5FC1C+348] mojo::FilterChain::Accept [0x00007FF7B56A95E7+151] mojo::Connector::ReadSingleMessage [0x00007FF7B4B59024+660] mojo::Connector::ReadAllAvailableMessages [0x00007FF7B4B59971+129] mojo::Connector::OnHandleReadyInternal [0x00007FF7B4B597D9+137] mojo::SimpleWatcher::OnHandleReady [0x00007FF7B4D46FC2+258] base::debug::TaskAnnotator::RunTask [0x00007FF7B647223B+347] base::MessageLoopImpl::RunTask [0x00007FF7B580D95E+270] base::MessageLoopImpl::DoWork [0x00007FF7B580DF97+407] base::MessagePumpForUI::DoRunLoop [0x00007FF7B4CAD4E9+169] base::MessagePumpWin::Run [0x00007FF7B4CACE3E+78] base::MessageLoopImpl::Run [0x00007FF7B580D5DB+139] base::RunLoop::Run [0x00007FF7B4CCD099+249] base::RunLoop::RunUntilIdle [0x00007FF7B4CCD730+112] content::Shell::CloseAllWindows [0x00007FF7B4B45697+119] content::ContentBrowserTest::PostRunTestOnMainThread [0x00007FF7B4B01FAF+111] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF7B4B0D342+946] content::ShellBrowserMainParts::PreMainMessageLoopRun [0x00007FF7B568AAFC+76] content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF7B378136E+62] content::StartupTaskRunner::RunAllTasksNow [0x00007FF7B3BA5D35+37] content::BrowserMainLoop::CreateStartupTasks [0x00007FF7B37801B2+786] content::BrowserMainRunnerImpl::Initialize [0x00007FF7B378382B+107] ShellBrowserMain [0x00007FF7B802564A+42] content::ShellMainDelegate::RunProcess [0x00007FF7B8023F0C+188] content::RunBrowserProcessMain [0x00007FF7B36863F9+89] content::ContentMainRunnerImpl::Run [0x00007FF7B3686E00+832] service_manager::Main [0x00007FF7B51C3CD3+2003] content::ContentMain [0x00007FF7B368633E+62] content::BrowserTestBase::SetUp [0x00007FF7B4B0CE5A+2218] testing::Test::Run [0x00007FF7B336D210+112] testing::TestInfo::Run [0x00007FF7B336DBF2+226] testing::TestCase::Run [0x00007FF7B336E172+258] testing::internal::UnitTestImpl::RunAllTests [0x00007FF7B3375A2E+638] testing::UnitTest::Run [0x00007FF7B33756F5+165] base::TestSuite::Run [0x00007FF7B4B34816+118] content::ContentTestLauncherDelegate::RunTestSuite [0x00007FF7B8022D4A+58] content::LaunchTests [0x00007FF7B4B26478+488] main [0x00007FF7B8022CEB+75] __scrt_common_main_seh [0x00007FF7B855C1E8+268] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x00007FFAD5552774+20] RtlUserThreadStart [0x00007FFAD5F40D51+33] """
,
Nov 29
juncai, could you take a look?
,
Nov 29
Sure, I'll take a look at that.
,
Dec 3
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dfaf338a6b7f5c283e093059fc9e8dbfcc7c1d1 commit 5dfaf338a6b7f5c283e093059fc9e8dbfcc7c1d1 Author: Jun Cai <juncai@chromium.org> Date: Thu Dec 06 20:55:10 2018 Network Service: Add DCHECK() for |callback_| in SiteDataClearer destructor This CL adds a DCHECK() in the SiteDataClearer destructor to make sure the |callback_| is already null when the destructor is called. Bug: 909826 Change-Id: I0cb3b039e23e16d3c827e9c877ea413619542158 Reviewed-on: https://chromium-review.googlesource.com/c/1359295 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#614484} [modify] https://crrev.com/5dfaf338a6b7f5c283e093059fc9e8dbfcc7c1d1/content/browser/browsing_data/clear_site_data_utils.cc
,
Dec 7
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mmenke@chromium.org
, Nov 28Labels: -Pri-3 Proj-Servicification-Stable Pri-2