[Tab loading animation] Have a different placeholder background colour for active versus background tabs |
|||
Issue descriptionFor active tabs the favicon placeholder still stands out too much especially for active foreground. Now the loading indicator is detached from the placeholder, the placeholder dominates the tab. Is it possible to introduce separate oolours for the placeholder based on tab state? The actual colours for foreground and background tabs TBD pending on whether we can do this. We may want to further recede the placeholder beyond the current 12% black anyway, but the ability to separate foreground from background tab means we can ensure we maintain a level of contrast.
,
Nov 28
Note this is for regular tabs only. Incognito and themed UI look good as there are.
,
Nov 28
bettes@ would like us to just switch the background colour to 5% black. Maybe there is no need to differentiate.
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a93d2a69fe805ad0e83622969a9291471cf67d5 commit 9a93d2a69fe805ad0e83622969a9291471cf67d5 Author: Peter Boström <pbos@chromium.org> Date: Thu Nov 29 22:57:27 2018 Use a fainter black for favicon placeholder Bug: chromium:909818 Change-Id: I0c0df3d6aa2e01a3107f6ed0e4920437d38a6f95 Reviewed-on: https://chromium-review.googlesource.com/c/1355611 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612418} [modify] https://crrev.com/9a93d2a69fe805ad0e83622969a9291471cf67d5/chrome/browser/ui/views/tabs/tab_icon.cc
,
Nov 29
Done! |
|||
►
Sign in to add a comment |
|||
Comment 1 by edwardjung@chromium.org
, Nov 28