Currently use counter log feature usage per page load. We would like to add a new histogram that only tracks feature usage on main frames. This would be beneficial for many use cases, sign exchange (whether from cache or not) as an example.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bac25cda793886129e559b146e19c9d4fca8c4d commit 6bac25cda793886129e559b146e19c9d4fca8c4d Author: Luna Lu <loonybear@chromium.org> Date: Tue Dec 18 21:40:49 2018 record use counter ukm/uma usage for features on main frames only Currently use counter only logs feature usage per page load. Usage from both main frams and sub frames are all counted towards one page load. This CL adds another histogram to use counter that only counts feature usage on main frame. Bug: 909812 Change-Id: I81597050e89e1857589e79c4e5449b644bc15651 Reviewed-on: https://chromium-review.googlesource.com/c/1354223 Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#617636} [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/BUILD.gn [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc [delete] https://crrev.com/d9447b7af71ee8fe35d090d66e33ff903d1fb00a/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.h [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.cc [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/6bac25cda793886129e559b146e19c9d4fca8c4d/tools/metrics/ukm/ukm.xml
Comment 1 by loonyb...@chromium.org
, Nov 28