New issue
Advanced search Search tips

Issue 909790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Extensions Click-to-Script: Remove context menu entry for sites the extension doesn't want to run on

Project Member Reported by rdevlin....@chromium.org, Nov 28

Issue description

Updated design is to remove the context menu page access submenu for sites the extension doesn't want to run on at all, and replace it with a "Can't read or change site's data" item.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c40a10c176b8375b6f9e3d949497f4d3952a2971

commit c40a10c176b8375b6f9e3d949497f4d3952a2971
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Nov 30 22:10:37 2018

[Extensions Click-to-Script] Adjust context menu options

Currently, if an extension is affected by runtime host permissions but
doesn't want to run on the current site, we still show the context menu
submenu entry for page access. The only item is the "Learn more" link.

Instead, remove the context menu submenu for these sites, and replace it
with a (disabled) menu item "Can't read or change site's data".

Bug:  909790 
Change-Id: Id77efca23a96e8d5d8f683954946970b652612d4
Reviewed-on: https://chromium-review.googlesource.com/c/1351302
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612813}
[modify] https://crrev.com/c40a10c176b8375b6f9e3d949497f4d3952a2971/chrome/app/generated_resources.grd
[modify] https://crrev.com/c40a10c176b8375b6f9e3d949497f4d3952a2971/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/c40a10c176b8375b6f9e3d949497f4d3952a2971/chrome/browser/extensions/extension_context_menu_model.h
[modify] https://crrev.com/c40a10c176b8375b6f9e3d949497f4d3952a2971/chrome/browser/extensions/extension_context_menu_model_unittest.cc

Status: Fixed (was: Started)
I think this should be fixed.

Sign in to add a comment