New issue
Advanced search Search tips

Issue 909785 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AnimationTiming calculations regarding active time and phase do not match spec

Project Member Reported by yigu@chromium.org, Nov 28

Issue description

Our codes do not match the spec in calculating the animation effect
phases [1] and its active time [2]. This patch updated the current
implementation by spec and fixed the related layout tests.

[1] https://drafts.csswg.org/web-animations/#before-active-boundary-time
[2] https://drafts.csswg.org/web-animations/#calculating-the-active-time
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26664074b27343684de423a753e644bd73f1b48a

commit 26664074b27343684de423a753e644bd73f1b48a
Author: Yi Gu <yigu@chromium.org>
Date: Mon Dec 03 18:22:10 2018

Fix AnimationTiming calculation regarding active time and phase

Our codes do not match the spec in calculating the animation effect
phases [1] and its active time [2]. This patch updated the current
implementation by spec and fixed the related layout tests.

[1] https://drafts.csswg.org/web-animations/#before-active-boundary-time
[2] https://drafts.csswg.org/web-animations/#calculating-the-active-time

Change-Id: Ia9ccea246835ddd2e2a3970d9279e008de9e699c
Bug:  909785 
Reviewed-on: https://chromium-review.googlesource.com/c/1352710
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613163}
[modify] https://crrev.com/26664074b27343684de423a753e644bd73f1b48a/third_party/blink/renderer/core/animation/animation_effect.cc
[modify] https://crrev.com/26664074b27343684de423a753e644bd73f1b48a/third_party/blink/renderer/core/animation/animation_effect.h
[modify] https://crrev.com/26664074b27343684de423a753e644bd73f1b48a/third_party/blink/renderer/core/animation/timing_calculations.h
[modify] https://crrev.com/26664074b27343684de423a753e644bd73f1b48a/third_party/blink/renderer/core/animation/timing_calculations_test.cc
[delete] https://crrev.com/583d3a0cd760b26f0272a579015929f36e2ce2a7/third_party/blink/web_tests/external/wpt/web-animations/timing-model/animation-effects/phases-and-states-expected.txt
[modify] https://crrev.com/26664074b27343684de423a753e644bd73f1b48a/third_party/blink/web_tests/external/wpt/web-animations/timing-model/animation-effects/simple-iteration-progress-expected.txt

Description: Show this description
Summary: AnimationTiming calculations regarding active time and phase do not match spec (was: Active time calculation of effect in before phase is incorrect)
Status: Fixed (was: Assigned)

Sign in to add a comment