New issue
Advanced search Search tips

Issue 909782 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move from MigrationSource enum to new UploadCardSource enum

Project Member Reported by jsaul@google.com, Nov 28

Issue description

MigrationSource is used here:
https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/payments_client.cc?l=323&rcl=257878d4a4463d1491def1b8cbde0049d247961d

We'd like to deprecate that and start using UploadCardSource (in the same place in Payments code).  This bug exists to track the migration in local card migration code.
 
Owner: siyua@google.com
Status: Assigned (was: Available)
Hey Siyu, could you take care of this migration, please?  Thanks!
Cc: siyua@chromium.org
Owner: jsaul@google.com
Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62202731420d841ad96099cbcde19492291b0947

commit 62202731420d841ad96099cbcde19492291b0947
Author: Jared Saul <jsaul@google.com>
Date: Fri Dec 14 19:45:04 2018

[Autofill] Use UploadCardSource in GetDetails requests

This CL moves from using MigrationSource (which was only applicable to
local card migration) to the new UploadCardSource enum (which applies to
both local card migration and normal card upload scenarios).

Bug: 909782
Change-Id: Ieef04c38b405bcb3fc17cbbb90a2ad66852c8c1e
Reviewed-on: https://chromium-review.googlesource.com/c/1377870
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#616792}
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/local_card_migration_manager.cc
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/local_card_migration_manager_unittest.cc
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/payments/payments_client.h
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/payments/test_payments_client.cc
[modify] https://crrev.com/62202731420d841ad96099cbcde19492291b0947/components/autofill/core/browser/payments/test_payments_client.h

Sign in to add a comment