New issue
Advanced search Search tips

Issue 909779 link

Starred by 1 user
Status: Assigned
Owner:
mdjones@chromium.org
Cc:
twelling...@chromium.org
tedc...@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Create generic list view adapter for MVC

Project Member Reported by mdjones@chromium.org, Nov 28 
We should support a generic list view adapter that knows how to take a list of models and build the resulting list view.

A few notes from offline discussions:

- PropertyModel should probably have a method "cloneEmpty" that copies all the properties but none of the data. This is an alternative to exposing all of a model's properties.

- Should view binder know how to create the view it is supposed to bind to?
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a2d7de6afc81def76755e45a120d57ac9daa51f

commit 4a2d7de6afc81def76755e45a120d57ac9daa51f
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed Nov 28 17:48:29 2018

Add ability to add custom views to omnibox suggestions

This patch adds the infrastructure to allow the omnibox suggestion
list to support custom view types. A view type is registered with the
adapter and the mediator is responsible for specifying the type of
view to be displayed.

Bug:909779

Change-Id: I2e3e6905fbf7e44d991c536134511e311078d1db
Reviewed-on: https://chromium-review.googlesource.com/c/1340947
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611763}
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsModel.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/modelutil/PropertyModel.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/modelutil/PropertyObservable.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java
[add] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionUiType.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListProperties.java
[modify] https://crrev.com/4a2d7de6afc81def76755e45a120d57ac9daa51f/chrome/android/java_sources.gni
►

Sign in to add a comment