The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/b67698386664fa06820a8dc7767660bc884c31e5

commit b67698386664fa06820a8dc7767660bc884c31e5
Author: Andrew Weintraub <asweintraub@google.com>
Date: Wed Nov 28 18:15:53 2018

Fix for a bug where no valid codepoints are recognized in certain PDFs.

Bug: chromium:909762 

Change-Id: Idd43d28130bd58292c085d9507f9e7ed5ca6c8be
Reviewed-on: https://pdfium-review.googlesource.com/c/45872
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/b67698386664fa06820a8dc7767660bc884c31e5/core/fpdfapi/font/cpdf_cmapparser.cpp

Let's verify this on tomorrow's Canary and then merge to M-71.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6e0a2ab707a009421b985cab0ce70da0f830fae

commit a6e0a2ab707a009421b985cab0ce70da0f830fae
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Nov 28 20:23:53 2018

Roll src/third_party/pdfium cb8a4ddc2277..b67698386664 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/cb8a4ddc2277..b67698386664


git log cb8a4ddc2277..b67698386664 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 asweintraub@google.com Fix for a bug where no valid codepoints are recognized in certain PDFs.


Created with:
  gclient setdep -r src/third_party/pdfium@b67698386664

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:909762 
TBR=dsinclair@chromium.org

Change-Id: Ib6b3b5038a133df9fcfc404253a3de0e5756b205
Reviewed-on: https://chromium-review.googlesource.com/c/1352868
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611851}
[modify] https://crrev.com/a6e0a2ab707a009421b985cab0ce70da0f830fae/DEPS

FWIW, this code has no unit / embedder / corpus test coverage. It is covered by fuzzers, likely with pdf_cmap_fuzzer, but that does not test for correctness. Plus nobody looks at the coverage data all the time, so nobody noticed the broken code meant the |nSegs| >= 1 cases were never hit. [1] (And thus the fuzzer it was slowing down ran a lot faster)

[1] https://chromium-coverage.appspot.com/reports/611497/linux/chromium/src/third_party/pdfium/core/fpdfapi/font/cpdf_cmapparser.cpp.html

 Issue 907496  has been merged into this issue.

Verified this is fixed, both with the original doc and with the doc in  bug 907496 .

Flipping OS bits.

This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M71 branch 3578based on comment #7. Pls merge ASAP, we're cutting M71 stable RC soon.

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/4a3dddbfe8fdcb69303ade5d74897513d56dbe3c

commit 4a3dddbfe8fdcb69303ade5d74897513d56dbe3c
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Nov 29 16:29:21 2018

M71: Fix for a bug where no valid codepoints are recognized in certain PDFs.

Bug:  chromium:909762 
TBR=tsepez@chromium.org

Change-Id: Idd43d28130bd58292c085d9507f9e7ed5ca6c8be
Reviewed-on: https://pdfium-review.googlesource.com/c/45872
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
(cherry picked from commit b67698386664fa06820a8dc7767660bc884c31e5)
Reviewed-on: https://pdfium-review.googlesource.com/c/46050

[modify] https://crrev.com/4a3dddbfe8fdcb69303ade5d74897513d56dbe3c/core/fpdfapi/font/cpdf_cmapparser.cpp

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/1e5fe4586347134f91b7156579a7975f4d8471ec

commit 1e5fe4586347134f91b7156579a7975f4d8471ec
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Nov 29 18:06:50 2018

Add a pixel test for a CPDF_CMapParser bug.

Bug:  chromium:909762 
Change-Id: I2a41aa8cc6639403b25be7fdfe82afff37231167
Reviewed-on: https://pdfium-review.googlesource.com/c/46033
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[add] https://crrev.com/1e5fe4586347134f91b7156579a7975f4d8471ec/testing/resources/pixel/bug_909762_expected_win.pdf.0.png
[add] https://crrev.com/1e5fe4586347134f91b7156579a7975f4d8471ec/testing/resources/pixel/bug_909762.in
[add] https://crrev.com/1e5fe4586347134f91b7156579a7975f4d8471ec/testing/resources/pixel/bug_909762_expected.pdf.0.png

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fdc6077d6e6835198cd446db441cc32592553ee

commit 8fdc6077d6e6835198cd446db441cc32592553ee
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Nov 29 22:06:16 2018

Roll src/third_party/pdfium c3daaa87ec17..5a88d16b87f5 (6 commits)

https://pdfium.googlesource.com/pdfium.git/+log/c3daaa87ec17..5a88d16b87f5


git log c3daaa87ec17..5a88d16b87f5 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 thestig@chromium.org Build pdfium_diff for coverage tests.
2018-11-29 thestig@chromium.org Remove some useless calculations in fxbarcode.
2018-11-29 tsepez@chromium.org Squeeze some more 0s out of wide font names.
2018-11-29 tsepez@chromium.org Squeeze out some 0s from cxfa_node_statics.cpp wide strings.
2018-11-29 thestig@chromium.org Roll third_party/freetype/src/ fb0d66d04..3dd4e76b1 (14 commits)
2018-11-29 thestig@chromium.org Add a pixel test for a CPDF_CMapParser bug.


Created with:
  gclient setdep -r src/third_party/pdfium@5a88d16b87f5

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:909762 
TBR=dsinclair@chromium.org

Change-Id: I144d909b776d173a9c24f2ac29bf0dca3fb80ccb
Reviewed-on: https://chromium-review.googlesource.com/c/1355623
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612397}
[modify] https://crrev.com/8fdc6077d6e6835198cd446db441cc32592553ee/DEPS