New issue
Advanced search Search tips

Issue 909753 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DeviceWiFiFastTransitionEnabled description is wrong

Project Member Reported by ljusten@chromium.org, Nov 28

Issue description

I'm referring to

If set to false, Fast Transition is not used.
If set to true, Fast Transition is used when the wireless access point supports it.

from this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1297644

The policy can't be set to false or true since it's not a bool. It's a dict with key 'enabled' that can be set to false or true.

 
Maybe an alternative would be to make it a regular bool policy.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564

commit cfef86c2c52dfa99ee3ec6717986a98e8e0cd564
Author: Matthew Wang <matthewmwang@chromium.org>
Date: Thu Nov 29 20:23:18 2018

Change FT pref to be a boolean instead of dictionary

FT pref used to be a dictionary with a single boolean field. Make
it a boolean instead.

Bug: 909753
TEST: shill unittests, browser_tests
Change-Id: I80304f6be20ebc9e7eec56f0dd2f36e2e8cf5af5
Reviewed-on: https://chromium-review.googlesource.com/c/1354343
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612336}
[modify] https://crrev.com/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564/chromeos/network/fast_transition_observer.cc
[modify] https://crrev.com/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564/chromeos/network/fast_transition_observer_unittest.cc
[modify] https://crrev.com/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564/components/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/cfef86c2c52dfa99ee3ec6717986a98e8e0cd564/components/policy/resources/policy_templates.json

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment