Catapult roller being blocked |
||||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/1352239 This is due to oilpan test failures: [20/25] contrib.oilpan.oilpan_gc_times_unittest.OilpanGCTimesTest.testForParsing failed unexpectedly 0.0015s: Traceback (most recent call last): File "/b/s/w/ir/tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py", line 130, in testForParsing data = self._GenerateDataForParsing() File "/b/s/w/ir/tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py", line 222, in _GenerateDataForParsing data = self._GenerateDataForEmptyPageSet() File "/b/s/w/ir/tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py", line 194, in _GenerateDataForEmptyPageSet data.results.WillRunPage(page) File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/results/page_test_results.py", line 462, in WillRunPage page, storyset_repeat_counter) File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/results/page_test_results.py", line 161, in WillRunStory self._UpdateDiagnostics() File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/results/page_test_results.py", line 218, in _UpdateDiagnostics for name, value in self.AsDict().items(): File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/results/page_test_results.py", line 193, in AsDict 'benchmark_name must be set exactly once') AssertionError: benchmark_name must be set exactly once Suspect this is caused by: 2018-11-26 eyaich@google.com Create method to add shared diagnostics to histograms not created through tbmv2 I will disable the oilpan unittests for now.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53166a7c0273d6df2a90e453c7727c5368f17861 commit 53166a7c0273d6df2a90e453c7727c5368f17861 Author: Ned Nguyen <nednguyen@google.com> Date: Wed Nov 28 16:52:51 2018 Disable OilpanGCTimesTest's failing tests which block catapult rolls They are: * contrib.oilpan.oilpan_gc_times_unittest.OilpanGCTimesTest.testForParsing * contrib.oilpan.oilpan_gc_times_unittest.OilpanGCTimesTest.testForParsingOldFormat NOTRY=true # Disabling CL only TBR=haraken@chromium.org, peria@chromium.org Bug: 909752 Change-Id: I87176fab5851ccc910fb5cc5dfede31880626423 Reviewed-on: https://chromium-review.googlesource.com/c/1354127 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#611733} [modify] https://crrev.com/53166a7c0273d6df2a90e453c7727c5368f17861/tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2d9ce867cb54341f5b89958711d6024c68d7b1f commit c2d9ce867cb54341f5b89958711d6024c68d7b1f Author: Emily Hanley <eyaich@google.com> Date: Mon Dec 03 16:34:15 2018 Fixing and enabling OilpanGCTimesTest Bug: 909752 Change-Id: Ic3556b4a2a4e403ab7c1ec4eacb1ada85b392668 Reviewed-on: https://chromium-review.googlesource.com/c/1355199 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#613118} [modify] https://crrev.com/c2d9ce867cb54341f5b89958711d6024c68d7b1f/tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py
,
Jan 8
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, Nov 28Labels: -Pri-3 Pri-1